Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix e2e network performance test #90486

Merged
merged 1 commit into from May 4, 2020
Merged

Conversation

aojea
Copy link
Member

@aojea aojea commented Apr 25, 2020

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespace from that line:

/kind api-change

/kind bug

/kind cleanup
/kind deprecation
/kind design
/kind documentation

/kind failing-test

/kind feature
/kind flake

What this PR does / why we need it:

The agnhost image has the agnhost binary as entrypoint.
The networking performance test need to run iperf overriding the entrypoint

Which issue(s) this PR fixes:

Fixes #90450

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:


@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/bug Categorizes issue or PR as related to a bug. kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Apr 25, 2020
@aojea
Copy link
Member Author

aojea commented Apr 25, 2020

/assign @thockin @dcbw
/sig network
/priority important-soon

@k8s-ci-robot k8s-ci-robot added area/test sig/network Categorizes an issue or PR as relevant to SIG Network. labels Apr 25, 2020
@k8s-ci-robot k8s-ci-robot added sig/testing Categorizes an issue or PR as relevant to SIG Testing. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Apr 25, 2020
@aojea
Copy link
Member Author

aojea commented Apr 25, 2020

I've tested it locally, don't know if this is running in some CI

bazel-bin/test/e2e/e2e.test -ginkgo.focus="Feature:Networking-Performance" -num-nodes 2
....
Apr 25 16:42:24.881: INFO: Selector matched 1 pods for map[app:iperf-e2e-cli-pod]
Apr 25 16:42:24.881: INFO: ForEach: Found 1 pods from the filter.  Now looping through them.
Apr 25 16:42:24.881: INFO: Running '/usr/local/bin/kubectl --server=https://127.0.0.1:35859 --kubeconfig=/home/aojeagarcia/.kube/config logs iperf-e2e-cli-pod-0 iperf-client --namespace=network-perf-7184'
Apr 25 16:42:24.999: INFO: stderr: ""
Apr 25 16:42:24.999: INFO: stdout: "20200425144219,10.244.1.7,55390,10.103.237.250,8002,3,0.0-10.0,41231187968,32984805241\n"
Apr 25 16:42:24.999: INFO: 20200425144219,10.244.1.7,55390,10.103.237.250,8002,3,0.0-10.0,41231187968,32984805241
....
Ran 2 of 5009 Specs in 50.958 seconds
SUCCESS! -- 2 Passed | 0 Failed | 0 Pending | 5007 Skipped

Copy link
Member

@SataQiu SataQiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 27, 2020
@aojea
Copy link
Member Author

aojea commented Apr 27, 2020

/retest

@aojea
Copy link
Member Author

aojea commented Apr 30, 2020

/assign @danwinship
do you mind take a look for approval?
it's a simple fix, the agnhost image has a binary as entrypoint, so we need to override it with a shell to be able to execute iperf inside.
I've tested the change locally

@aojea
Copy link
Member Author

aojea commented May 1, 2020

/retest

@cmluciano
Copy link

@aojea I don't have approver power but will try this out locally and give another review. Can you confirm how you ran this test locally? I'm gonna try a kubetest build against a cloud cluster.

@aojea
Copy link
Member Author

aojea commented May 1, 2020

@aojea I don't have approver power but will try this out locally and give another review. Can you confirm how you ran this test locally? I'm gonna try a kubetest build against a cloud cluster.

I test it using kind kubernetes-sigs/kind#1181 (comment)

@danwinship
Copy link
Contributor

I've tested it locally, don't know if this is running in some CI

It probably runs in one of the periodic jobs, not something you can run from a PR. One way to get around that is to just push a temporary commit changing the tags on the test you want to run so it's no longer skipped in the default runs. But anyway, the fix looks right and you tested it.

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aojea, danwinship

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 4, 2020
@k8s-ci-robot k8s-ci-robot merged commit dca3e3f into kubernetes:master May 4, 2020
@k8s-ci-robot k8s-ci-robot added this to the v1.19 milestone May 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note-none Denotes a PR that doesn't merit a release note. sig/network Categorizes an issue or PR as relevant to SIG Network. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

E2E: networking_perf.go test erroring out
7 participants