New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert "Send watch bookmarks every minute" #90524
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
size/S
Denotes a PR that changes 10-29 lines, ignoring generated files.
do-not-merge/release-note-label-needed
Indicates that a PR should not merge because it's missing one of the release note labels.
cncf-cla: yes
Indicates the PR's author has signed the CNCF CLA.
needs-kind
Indicates a PR lacks a `kind/foo` label and requires one.
needs-sig
Indicates an issue or PR lacks a `sig/foo` label and requires one.
needs-priority
Indicates a PR lacks a `priority/foo` label and requires one.
release-note-none
Denotes a PR that doesn't merit a release note.
area/apiserver
sig/api-machinery
Categorizes an issue or PR as relevant to SIG API Machinery.
and removed
do-not-merge/release-note-label-needed
Indicates that a PR should not merge because it's missing one of the release note labels.
needs-sig
Indicates an issue or PR lacks a `sig/foo` label and requires one.
labels
Apr 27, 2020
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: wojtek-t The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Indicates a PR has been approved by an approver from all required OWNERS files.
label
Apr 27, 2020
/lgtm |
k8s-ci-robot
added
the
lgtm
"Looks good to me", indicates that a PR is ready to be merged.
label
Apr 27, 2020
wojtek-t
added
kind/bug
Categorizes issue or PR as related to a bug.
priority/important-soon
Must be staffed and worked on either currently, or very soon, ideally in time for the next release.
and removed
needs-kind
Indicates a PR lacks a `kind/foo` label and requires one.
needs-priority
Indicates a PR lacks a `priority/foo` label and requires one.
labels
Apr 27, 2020
/retest |
3 similar comments
/retest |
/retest |
/retest |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
approved
Indicates a PR has been approved by an approver from all required OWNERS files.
area/apiserver
cncf-cla: yes
Indicates the PR's author has signed the CNCF CLA.
kind/bug
Categorizes issue or PR as related to a bug.
lgtm
"Looks good to me", indicates that a PR is ready to be merged.
priority/important-soon
Must be staffed and worked on either currently, or very soon, ideally in time for the next release.
release-note-none
Denotes a PR that doesn't merit a release note.
sig/api-machinery
Categorizes an issue or PR as relevant to SIG API Machinery.
size/S
Denotes a PR that changes 10-29 lines, ignoring generated files.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #90249
Reverting because watchers are not readded to send another bookmark later.