Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update find-binary-for-platform to work with non-GNU versions of find #90617

Merged
merged 1 commit into from May 4, 2020
Merged

Update find-binary-for-platform to work with non-GNU versions of find #90617

merged 1 commit into from May 4, 2020

Conversation

CecileRobertMichon
Copy link
Member

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespace from that line:

/kind api-change
/kind bug
/kind cleanup
/kind deprecation
/kind design
/kind documentation
/kind failing-test
/kind feature
/kind flake

What this PR does / why we need it: This change allows finding bazel-bin binaries when running /hack/ginkgo-e2e.sh from MacOS (or in general a platform that uses a BSD version of find which doesn't recognize -executable).

For more info on the differences between find on Linux vs MacOS https://linux.die.net/man/1/find and https://ss64.com/osx/find.html.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Apr 29, 2020
@CecileRobertMichon
Copy link
Member Author

I'm not sure what kind label to apply since this is changing a hack/ util script only and there doesn't seem to be any fitting one for that

This was referenced Apr 29, 2020
Merged
Closed
@CecileRobertMichon
Copy link
Member Author

/retest

@CecileRobertMichon
Copy link
Member Author

/sig release
/sig testing

@k8s-ci-robot k8s-ci-robot added sig/release Categorizes an issue or PR as relevant to SIG Release. sig/testing Categorizes an issue or PR as relevant to SIG Testing. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Apr 30, 2020
@CecileRobertMichon
Copy link
Member Author

/retest

@justaugustus
Copy link
Member

/test pull-kubernetes-files-remake
/cc @kubernetes/bash-firefighters

@CecileRobertMichon
Copy link
Member Author

/assign @eparis

@eparis apologies if you're not the right person to review this, could you please point me to the right people? Not sure who owns the hack/ scripts (the bot named you)

@k8s-ci-robot k8s-ci-robot assigned eparis and unassigned eparis Apr 30, 2020
cblecker
cblecker reviewed Apr 30, 2020
View reviewed changes
Copy link
Member

@cblecker cblecker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/unassign @eparis
/assign

hack/lib/util.sh Outdated Show resolved Hide resolved
BenTheElder
BenTheElder reviewed Apr 30, 2020
View reviewed changes
hack/lib/util.sh Outdated Show resolved Hide resolved
@BenTheElder
Copy link
Member

FYI this is not the only place we require:

  • gnu utils
  • bash more recent than what macOS ships by default (given the linked issues I assume this is relevant 🙃 )

I am +1 on trying to be more portable though :-)

@CecileRobertMichon
Copy link
Member Author

/retest

@CecileRobertMichon
Copy link
Member Author

As discussed in comments above, I changed the command to use -perm -111 which is closer to -executable but not exactly equivalent, so keeping the existing find command as-is and making the change additive.

@CecileRobertMichon
Copy link
Member Author

I don't think the gce failure is related 😕

/retest

@CecileRobertMichon
Copy link
Member Author

/retest

@BenTheElder
Copy link
Member

sorry about that, our tests are definitely flaky ... at least some of the flakes are tracked

@BenTheElder
Copy link
Member

/lgtm
/approve
thanks!

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 2, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: BenTheElder, CecileRobertMichon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 2, 2020
@CecileRobertMichon
Copy link
Member Author

/kind bug

@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. and removed needs-kind Indicates a PR lacks a `kind/foo` label and requires one. labels May 4, 2020
@k8s-ci-robot k8s-ci-robot merged commit b15c38e into kubernetes:master May 4, 2020
@k8s-ci-robot k8s-ci-robot added this to the v1.19 milestone May 4, 2020
@CecileRobertMichon CecileRobertMichon mentioned this pull request May 6, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BenTheElder BenTheElder BenTheElder left review comments

@cblecker cblecker cblecker left review comments

@juanvallejo juanvallejo Awaiting requested review from juanvallejo

@xichengliudui xichengliudui Awaiting requested review from xichengliudui

Assignees

@BenTheElder BenTheElder

@cblecker cblecker

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. release-note-none Denotes a PR that doesn't merit a release note. sig/release Categorizes an issue or PR as relevant to SIG Release. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v1.19
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@CecileRobertMichon @justaugustus @BenTheElder @k8s-ci-robot @cblecker @eparis