Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Option to avoid running files-remake in verify-all #90646

Merged
merged 1 commit into from Apr 30, 2020
Merged

Option to avoid running files-remake in verify-all #90646

merged 1 commit into from Apr 30, 2020

Conversation

dims
Copy link
Member

@dims dims commented Apr 30, 2020

Signed-off-by: Davanum Srinivas davanum@gmail.com

What type of PR is this?
/kind failing-test

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@dims
Avoid running files-remake in verify-all
14a0e86 
Signed-off-by: Davanum Srinivas <davanum@gmail.com>
@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Apr 30, 2020
@dims dims changed the title Avoid running files-remake in verify-all Option to avoid running files-remake in verify-all Apr 30, 2020
@k8s-ci-robot k8s-ci-robot requested review from hwdef and ixdy April 30, 2020 16:00
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dims

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 30, 2020
@dims
Copy link
Member Author

dims commented Apr 30, 2020

/sig testing
/priority critical-urgent

@k8s-ci-robot k8s-ci-robot added sig/testing Categorizes an issue or PR as relevant to SIG Testing. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Apr 30, 2020
@dims
Copy link
Member Author

dims commented Apr 30, 2020

/assign @cblecker @spiffxp

@spiffxp spiffxp merged commit 9380cb1 into kubernetes:master Apr 30, 2020
@k8s-ci-robot k8s-ci-robot added this to the v1.19 milestone Apr 30, 2020
@spiffxp
Copy link
Member

spiffxp commented Apr 30, 2020

breaking glass and merging this by hand because this fix is unlikely to merge on its own (ref: #90647)

@spiffxp
Copy link
Member

spiffxp commented Apr 30, 2020

this is needed by kubernetes/test-infra#17454

@spiffxp spiffxp mentioned this pull request Apr 30, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hwdef hwdef Awaiting requested review from hwdef

@ixdy ixdy Awaiting requested review from ixdy

Assignees

@spiffxp spiffxp

@cblecker cblecker

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. release-note-none Denotes a PR that doesn't merit a release note. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v1.19
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@dims @k8s-ci-robot @spiffxp @cblecker