Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use conntrack instead of the /proc file for the e2e test TCP CLOSE_WAIT #90687

Merged
merged 2 commits into from May 11, 2020
Merged

use conntrack instead of the /proc file for the e2e test TCP CLOSE_WAIT #90687

merged 2 commits into from May 11, 2020

Conversation

aojea
Copy link
Member

@aojea aojea commented May 2, 2020 •
edited

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespace from that line:

/kind api-change
/kind bug

/kind cleanup

/kind deprecation
/kind design
/kind documentation
/kind failing-test
/kind feature

/kind flake

What this PR does / why we need it:

Some distros no longer mount the /proc/net/nf_conntrack file, also it seems to have performance issues on host with lots of connection entries.

Switch to conntrack using the debian-iptables image, that is the base image used for the
kube-proxy one.

It already has the conntrack command, so no need to check for it.

xref: #69589 (comment)

Which issue(s) this PR fixes:

Fixes #71565

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@k8s-ci-robot k8s-ci-robot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. kind/flake Categorizes issue or PR as related to a flaky test. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels May 2, 2020
@aojea
Copy link
Member Author

aojea commented May 2, 2020

/sig network
/sig testing

@k8s-ci-robot k8s-ci-robot added sig/network Categorizes an issue or PR as relevant to SIG Network. sig/testing Categorizes an issue or PR as relevant to SIG Testing. area/test and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels May 2, 2020
@aojea aojea force-pushed the connt branch 4 times, most recently from 4da7fd3 to a6f8331 Compare May 2, 2020 16:37
@aojea
Copy link
Member Author

aojea commented May 2, 2020

/assign @BenTheElder @spiffxp
/cc @oomichi

It works for IPv4 and IPv6

@k8s-ci-robot k8s-ci-robot requested a review from oomichi May 2, 2020 16:46
@aojea aojea changed the title use conntrack instead of the /proc file use conntrack instead of the /proc file for the e2e test TCP CLOSE_WAIT May 2, 2020
@aojea
Copy link
Member Author

aojea commented May 2, 2020

/priority important-soon

@k8s-ci-robot k8s-ci-robot added priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. and removed needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels May 2, 2020
@aojea aojea mentioned this pull request May 2, 2020
Merged
BenTheElder
BenTheElder reviewed May 2, 2020
View reviewed changes
test/utils/image/manifest.go Outdated Show resolved Hide resolved
test/e2e/network/kube_proxy.go Show resolved Hide resolved
@justaugustus
Copy link
Member

justaugustus commented May 9, 2020 •
edited

does it means that k8s.gcr.io/debian-iptables:v12.1.0 should work?

@aojea -- Not until we move k8s.gcr.io to point to {asia,eu,us}.gcr.io/k8s-artifacts-prod (instead of gcr.io/google-containers).
That migration is happening later this month and is tracked on kubernetes/release#270.

@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@justaugustus
Copy link
Member

/hold to stop the retests
Feel free to lift the hold once my review is addressed.

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 9, 2020
@aojea
use conntrack instead of the /proc file
5c8b88e 
use the debian-iptables image, that is the base image used for the
kube-proxy one.

It already has the conntrack command, so no need to check for it.
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 9, 2020
@justaugustus
Copy link
Member

/test pull-kubernetes-integration

@aojea
Copy link
Member Author

aojea commented May 9, 2020

/hold cancel
tests are passing now, it should mean the images are correct now

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 9, 2020
@justaugustus
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 9, 2020
@aojea
Copy link
Member Author

aojea commented May 9, 2020 •
edited

heh, seems I'm hitting all the block in the road 🙃

test/utils/image/manifest.go:35:2: struct field tag yaml:"buildImageRegistry not compatible with reflect.StructTag.Get: bad syntax for struct tag value

--
🤕 missing trailing quote

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 9, 2020
@aojea
Copy link
Member Author

aojea commented May 9, 2020

/test pull-kubernetes-integration
/test pull-kubernetes-e2e-gce
unrelated failures

@aojea
Copy link
Member Author

aojea commented May 9, 2020

/test pull-kubernetes-integration

🤔

@aojea
Copy link
Member Author

aojea commented May 9, 2020

/test pull-kubernetes-integration

🤔 different failures and unrelated to this PR

@justaugustus
Copy link
Member

/retest

@aojea
Copy link
Member Author

aojea commented May 10, 2020

ping @justaugustus , can I have a final (hopefully) lgtm?

@justaugustus
Copy link
Member

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 10, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aojea, BenTheElder, justaugustus

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@aojea
Copy link
Member Author

aojea commented May 10, 2020

/test pull-kubernetes-integration

@justaugustus
Copy link
Member

/retest

@k8s-ci-robot k8s-ci-robot merged commit 7937aa6 into kubernetes:master May 11, 2020
@k8s-ci-robot k8s-ci-robot added this to the v1.19 milestone May 11, 2020
@aojea aojea deleted the connt branch May 11, 2020 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@neolit123 neolit123 neolit123 left review comments

@BenTheElder BenTheElder BenTheElder left review comments

@justaugustus justaugustus justaugustus requested changes

@johnbelamaric johnbelamaric Awaiting requested review from johnbelamaric

@MrHohn MrHohn Awaiting requested review from MrHohn

@oomichi oomichi Awaiting requested review from oomichi

Assignees

@spiffxp spiffxp

@justaugustus justaugustus

@BenTheElder BenTheElder

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. kind/flake Categorizes issue or PR as related to a flaky test. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note-none Denotes a PR that doesn't merit a release note. sig/network Categorizes an issue or PR as relevant to SIG Network. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v1.19
Development

Successfully merging this pull request may close these issues.

Flake: [sig-network] Network should set TCP CLOSE_WAIT timeout
7 participants
@aojea @BenTheElder @justaugustus @fejta-bot @k8s-ci-robot @neolit123 @spiffxp