Avoid early exit when collecting post-E2E failure logs.

[fasaxc]

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespace from that line:

/kind api-change
/kind bug

/kind cleanup

/kind deprecation
/kind design
/kind documentation
/kind failing-test
/kind feature
/kind flake

What this PR does / why we need it:

collectPodsAndNetworkPolicies() is called to collect diagnostics after an E2E failure. Previously, if it encountered a failure in getting the logs it would call Failf(); this discards the rest of the diagnostics and the primary failure message itself. Since it's only called when Failf is already guaranteed to be called, simply demoting it to a log seems reasonable.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

[k8s-ci-robot]

Hi @fasaxc. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[fasaxc]

/assign @caseydavenport

[caseydavenport]

This seems right to me - I've definitely seen the same in tests I've run.

/lgtm

[cmluciano]

/ok-to-test

[fasaxc]

Looks like the failing test is a known flake: #87468

[fasaxc]

/retest

[cmluciano]

This looks ok to me given the context but we do miss out on the stacktrace. I'm guessing this is fine because it would probably just reflect what the comment says (couldn't get previous pod logs because they are already removed).

[oomichi]

After applying this PR, all error handling in collectPodsAndNetworkPolicies() are the same(just Logf).
Looks fine for me.

/lgtm

[fasaxc]

Can I get a /approve?

[oomichi]

/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fasaxc, oomichi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• test/e2e/network/OWNERS [oomichi]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment