Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: use annotation to filter AWS LB target nodes #90943

Merged

Conversation

foobarfran
Copy link
Contributor

What type of PR is this?
/kind feature
/area provider/aws

What this PR does / why we need it:
This pull request allows to target specific nodes in AWS LoadBalancer Services, using an annotation to specify a comma separated list of key=values, used to match node labels.
A common scenario is to use pod affinity to target specific nodes, this PR allows to extend that behaviour to the service level having the following improvements:

  • Keep traffic in the instances that can answer requests
  • When we use externalTrafficPolicy: Local in our service, we get rid of the Unhealthy ec2 instances in the aws target groups for those nodes that doesn't have any pods for the service, improving the TG monitoring simplicity
  • For large clusters, we prevent to rapidly reach the target limit in the target group, specially if the service exposes multiple ports.

Which issue(s) this PR fixes:
Fixes (kubernetes/cloud-provider-aws#58)

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Added service.beta.kubernetes.io/aws-load-balancer-target-node-labels annotation to target nodes in AWS LoadBalancer Services

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/feature Categorizes issue or PR as related to a new feature. labels May 10, 2020
@k8s-ci-robot
Copy link
Contributor

@foobarfran: The label(s) area/ cannot be applied, because the repository doesn't have them

In response to this:

What type of PR is this?
/kind feature
/area provider/aws

What this PR does / why we need it:
This pull request allows to target specific nodes in AWS LoadBalancer Services, using an annotation to specify a comma separated list of key=values, used to match node labels.
A common scenario is to use pod affinity to target specific nodes, this PR allows to extend that behaviour to the service level having the following improvements:

  • Keep traffic in the instances that can answer requests
  • When we use externalTrafficPolicy: Local in our service, we get rid of the Unhealthy ec2 instances in the aws target groups for those nodes that doesn't have any pods for the service, improving the TG monitoring simplicity
  • For large clusters, we prevent to rapidly reach the target limit in the target group, specially if the service exposes multiple ports.

Which issue(s) this PR fixes:
Fixes (kubernetes/cloud-provider-aws#58)

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Added service.beta.kubernetes.io/aws-load-balancer-target-node-labels annotation to target nodes in AWS LoadBalancer Services

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. area/provider/aws Issues or PRs related to aws provider labels May 10, 2020
@k8s-ci-robot
Copy link
Contributor

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.


Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels May 10, 2020
@k8s-ci-robot
Copy link
Contributor

Welcome @foobarfran!

It looks like this is your first PR to kubernetes/kubernetes 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/kubernetes has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label May 10, 2020
@k8s-ci-robot
Copy link
Contributor

Hi @foobarfran. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added area/cloudprovider sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels May 10, 2020
@foobarfran foobarfran force-pushed the feature-aws-lb-node-targeting branch from 61c6aca to bd08500 Compare May 10, 2020 01:02
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels May 10, 2020
@foobarfran foobarfran force-pushed the feature-aws-lb-node-targeting branch from bd08500 to 0bfad41 Compare May 12, 2020 14:03
@foobarfran
Copy link
Contributor Author

/cc @M00nF1sh

@foobarfran foobarfran force-pushed the feature-aws-lb-node-targeting branch from 0bfad41 to 8e9e2ef Compare May 26, 2020 21:27
@foobarfran foobarfran force-pushed the feature-aws-lb-node-targeting branch from 8e9e2ef to c76eeba Compare May 26, 2020 22:20
Copy link
Contributor

@M00nF1sh M00nF1sh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ok-to-test
/lgtm

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels May 26, 2020
@foobarfran foobarfran force-pushed the feature-aws-lb-node-targeting branch from c76eeba to 70820bb Compare May 27, 2020 00:02
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 27, 2020
@foobarfran foobarfran requested a review from M00nF1sh May 27, 2020 00:12
@foobarfran
Copy link
Contributor Author

/retest

@M00nF1sh
Copy link
Contributor

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 27, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: foobarfran, M00nF1sh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 27, 2020
@foobarfran
Copy link
Contributor Author

/retest

3 similar comments
@foobarfran
Copy link
Contributor Author

/retest

@foobarfran
Copy link
Contributor Author

/retest

@foobarfran
Copy link
Contributor Author

/retest

@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

1 similar comment
@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@foobarfran
Copy link
Contributor Author

/retest

2 similar comments
@foobarfran
Copy link
Contributor Author

/retest

@foobarfran
Copy link
Contributor Author

/retest

@k8s-ci-robot k8s-ci-robot merged commit 74b857c into kubernetes:master May 28, 2020
@k8s-ci-robot k8s-ci-robot added this to the v1.19 milestone May 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/cloudprovider area/provider/aws Issues or PRs related to aws provider cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants