New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: use annotation to filter AWS LB target nodes #90943
feat: use annotation to filter AWS LB target nodes #90943
Conversation
@foobarfran: The label(s) In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA. It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Welcome @foobarfran! |
Hi @foobarfran. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
61c6aca
to
bd08500
Compare
bd08500
to
0bfad41
Compare
/cc @M00nF1sh |
0bfad41
to
8e9e2ef
Compare
staging/src/k8s.io/legacy-cloud-providers/aws/aws_loadbalancer.go
Outdated
Show resolved
Hide resolved
8e9e2ef
to
c76eeba
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/ok-to-test
/lgtm
c76eeba
to
70820bb
Compare
/retest |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: foobarfran, M00nF1sh The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
3 similar comments
/retest |
/retest |
/retest |
/retest Review the full test history for this PR. Silence the bot with an |
1 similar comment
/retest Review the full test history for this PR. Silence the bot with an |
/retest |
2 similar comments
/retest |
/retest |
What type of PR is this?
/kind feature
/area provider/aws
What this PR does / why we need it:
This pull request allows to target specific nodes in AWS LoadBalancer Services, using an annotation to specify a comma separated list of key=values, used to match node labels.
A common scenario is to use pod affinity to target specific nodes, this PR allows to extend that behaviour to the service level having the following improvements:
externalTrafficPolicy: Local
in our service, we get rid of theUnhealthy
ec2 instances in the aws target groups for those nodes that doesn't have any pods for the service, improving the TG monitoring simplicityWhich issue(s) this PR fixes:
Fixes (kubernetes/cloud-provider-aws#58)
Special notes for your reviewer:
Does this PR introduce a user-facing change?:
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: