Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update and improve ConfigMap resource lifecycle test #90944

Merged
merged 22 commits into from Jun 17, 2020
Merged

Update and improve ConfigMap resource lifecycle test #90944

merged 22 commits into from Jun 17, 2020

Conversation

Riaankl
Copy link
Contributor

@Riaankl Riaankl commented May 10, 2020 •
edited

What type of PR is this?
/kind cleanup

What this PR does / why we need it:
Adds more checks throughout the test:

  • created
  • modified
  • deleted

Which issue(s) this PR fixes:
Fixes #90921
Resolves #90957

#88034 (comment)
(#88034 (comment))

Special notes for your reviewer:
Should fix flakiness

Does this PR introduce a user-facing change?:

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

NONE

/sig testing

@k8s-ci-robot k8s-ci-robot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. sig/testing Categorizes an issue or PR as relevant to SIG Testing. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels May 10, 2020
@Riaankl Riaankl mentioned this pull request May 10, 2020
Closed
9 tasks
@Riaankl
Copy link
Contributor Author

Riaankl commented May 10, 2020

#89707 (comment)

@Riaankl Riaankl mentioned this pull request May 10, 2020
Closed
4 tasks
@Riaankl Riaankl added this to PRs Needing Review in conformance-definition May 10, 2020
@fejta-bot
Copy link

Unknown CLA label state. Rechecking for CLA labels.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/check-cla

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label May 10, 2020
@hh
Copy link
Member

hh commented May 10, 2020

/assign @BobyMCbobs

@matthyx
Copy link
Contributor

matthyx commented May 13, 2020

/uncc

@k8s-ci-robot k8s-ci-robot removed the request for review from matthyx May 13, 2020 07:35
@Riaankl Riaankl mentioned this pull request May 25, 2020
Merged
@Riaankl
Copy link
Contributor Author

Riaankl commented May 26, 2020

/test pull-kubernetes-e2e-kind
/test pull-kubernetes-e2e-gce-100-performance

@BobyMCbobs BobyMCbobs force-pushed the ii-update-and-improve-configmap-resource-lifecycle-test branch from ad7d11a to 86a6763 Compare June 3, 2020 22:47
@BobyMCbobs
Copy link
Member

/retest

1 similar comment
@BobyMCbobs
Copy link
Member

/retest

@BobyMCbobs BobyMCbobs force-pushed the ii-update-and-improve-configmap-resource-lifecycle-test branch from 86a6763 to 86d216d Compare June 9, 2020 22:53
@BobyMCbobs
Copy link
Member

/retest

1 similar comment
@BobyMCbobs
Copy link
Member

/retest

@BobyMCbobs BobyMCbobs force-pushed the ii-update-and-improve-configmap-resource-lifecycle-test branch from 86d216d to 34ddb64 Compare June 11, 2020 02:10
@BobyMCbobs BobyMCbobs mentioned this pull request Jun 11, 2020
Merged
@BobyMCbobs
Copy link
Member

/retest

@spiffxp
Copy link
Member

spiffxp commented Jun 16, 2020

/release-note-none

/approve
/lgtm
to get us some signal, I'm still not convinced this is the right way to go, will summarize in another comment

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Jun 16, 2020
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 16, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Riaankl, spiffxp

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 16, 2020
@k8s-ci-robot k8s-ci-robot merged commit 580eebb into kubernetes:master Jun 17, 2020
conformance-definition automation moved this from PRs Needing Review to Done Jun 17, 2020
@k8s-ci-robot k8s-ci-robot added this to the v1.19 milestone Jun 17, 2020
@spiffxp
Copy link
Member

spiffxp commented Jun 19, 2020

/area conformance

@k8s-ci-robot k8s-ci-robot added the area/conformance Issues or PRs related to kubernetes conformance tests label Jun 19, 2020
@spiffxp spiffxp mentioned this pull request Jun 29, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@feiskyer feiskyer Awaiting requested review from feiskyer

Assignees

@spiffxp spiffxp

@BobyMCbobs BobyMCbobs

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/conformance Issues or PRs related to kubernetes conformance tests area/e2e-test-framework Issues or PRs related to refactoring the kubernetes e2e test framework area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. release-note-none Denotes a PR that doesn't merit a release note. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
conformance-definition
  
Done
Milestone
v1.19
Development

Successfully merging this pull request may close these issues.

Watch event test verification tooling Write CoreV1ConfigMap test - +2 endpoint Coverage
7 participants
@Riaankl @fejta-bot @hh @matthyx @BobyMCbobs @spiffxp @k8s-ci-robot