Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Automated cherry pick of #90248: Add back anti-affinity to kube-dns pods. #91061

Merged
merged 1 commit into from May 21, 2020
Merged

Automated cherry pick of #90248: Add back anti-affinity to kube-dns pods. #91061

merged 1 commit into from May 21, 2020

Conversation

prameshj
Copy link
Contributor

Cherry pick of #90248 on release-1.17.

#90248: Add back anti-affinity to kube-dns pods.

For details on the cherry pick process, see the cherry pick requests page.

@prameshj
Add back anti-affinity to kube-dns pods.
4872b21 
This change also updates to the latest kube-dns images. The
anti-affinity change was previously rolled back in kubernetes#59357
Adding this back as there have been imrpovements in scheduler
performance since.
@k8s-ci-robot k8s-ci-robot added the do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. label May 13, 2020
@k8s-ci-robot k8s-ci-robot added this to the v1.17 milestone May 13, 2020
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels May 13, 2020
@prameshj prameshj mentioned this pull request May 13, 2020
Merged
@k8s-ci-robot k8s-ci-robot requested review from bowei and MrHohn May 13, 2020 13:38
@k8s-ci-robot k8s-ci-robot added sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels May 13, 2020
@prameshj
Copy link
Contributor Author

/release-note-none
/assign @MrHohn @alculquicondor

@k8s-ci-robot k8s-ci-robot added the release-note-none Denotes a PR that doesn't merit a release note. label May 13, 2020
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. label May 13, 2020
@alculquicondor
Copy link
Member

This has been verified to not cause performance regressions in 1.17

/lgtm

from SIG scheduling

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 13, 2020
MrHohn
MrHohn approved these changes May 13, 2020
View reviewed changes
Copy link
Member

@MrHohn MrHohn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: MrHohn, prameshj

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 13, 2020
@tpepper
Copy link
Member

tpepper commented May 15, 2020

/kind feature
from parent PR.

@prameshj generally we don't backport features, can you confirm with the code OWNERS whether this is something to cherry pick to 1.18 and 1.17?

@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. and removed needs-kind Indicates a PR lacks a `kind/foo` label and requires one. labels May 15, 2020
@tosi3k tosi3k mentioned this pull request May 15, 2020
Merged
@prameshj
Copy link
Contributor Author

Since this is a change to spread kube-dns pods across nodes and thereby help prevent single point of failure of DNS, I was hoping this could be considered as a backport candidate.
cc @MrHohn @bowei

@justaugustus
Copy link
Member

/retest

@tpepper
Copy link
Member

tpepper commented May 19, 2020

Discussed in SIG Release today: We're ok with the reassessment of this being a bug. Since we're past the cherry pick deadline for this week and have some CI instability on 1.18/1.17, we plan to cherry pick approve for merge after Wednesday's expected May patch release is cut. This means we will have time to see if we hit any scale issues on 1.19/1.18/1.17 and do any additional fixups ahead of June's patch releases.

@prameshj
Copy link
Contributor Author

Discussed in SIG Release today: We're ok with the reassessment of this being a bug. Since we're past the cherry pick deadline for this week and have some CI instability on 1.18/1.17, we plan to cherry pick approve for merge after Wednesday's expected May patch release is cut. This means we will have time to see if we hit any scale issues on 1.19/1.18/1.17 and do any additional fixups ahead of June's patch releases.

Thanks Tim and Stephen! Also want to note that we are only cherrypicking only as far back as 1.17 since most scheduling improvements were done in that version. Older versions might have performance regression with this change.

@tpepper
Copy link
Member

tpepper commented May 20, 2020

Discussed in SIG Release today: We're ok with the reassessment of this being a bug. Since we're past the cherry pick deadline for this week and have some CI instability on 1.18/1.17, we plan to cherry pick approve for merge after Wednesday's expected May patch release is cut. This means we will have time to see if we hit any scale issues on 1.19/1.18/1.17 and do any additional fixups ahead of June's patch releases.

as per ^^
/kind bug

@k8s-ci-robot k8s-ci-robot added the kind/bug Categorizes issue or PR as related to a bug. label May 20, 2020
@tpepper tpepper added cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. and removed kind/feature Categorizes issue or PR as related to a new feature. labels May 20, 2020
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. label May 20, 2020
@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@k8s-ci-robot k8s-ci-robot merged commit 34646ff into kubernetes:release-1.17 May 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MrHohn MrHohn MrHohn approved these changes

@bowei bowei Awaiting requested review from bowei

Assignees

@alculquicondor alculquicondor

@MrHohn MrHohn

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. release-note-none Denotes a PR that doesn't merit a release note. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v1.17
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@prameshj @alculquicondor @k8s-ci-robot @tpepper @justaugustus @fejta-bot @MrHohn