gce-Instances NodeAddresses: Add check for multiple interface IPs

[kaivalya97]

What type of PR is this?
/kind design

What this PR does / why we need it:
The NodeAddresses function only checked for IPs on the default interface. If kubelet is initialized with a non-default interface on a GCE VM, kubectl get nodes does not give an IP.

Which issue(s) this PR fixes:

Fixes #90570

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

[k8s-ci-robot]

Hi @kaivalya97. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[kaivalya97]

@cheftako

[cheftako]

/ok-to-test

[cheftako]

/hold #90738 I would like to merge your other PR first.

[kaivalya97]

/retest

[kaivalya97]

@cheftako @andrewsykim Please review and approve

I checked aws.go and even there the NodeAddresses function returns IPs from all NICs

[cheftako]

/cc @dchen1107 @karan

[cheftako]

So this particular usage of NodeAddresses() should only be invoked on the Kubelet. That use case is deprecated and should be removed as part of the cloud provider extraction effort. Assuming sig-node has no issue with these changes, I am fine with them but do want to make sure you are aware that the code path which invokes this usage is going away.

[cheftako]

/lgtm

[cheftako]

#90738 has merged, will remove hold soon. Would like to make sure dchen1107, karan have not objections.

[kaivalya97]

Yes so I have also made changes to nodeAddressesFromInstance() which is called in case the code is not run from kubelet

[cheftako]

/remove hold

[cheftako]

/hold cancel

[cheftako]

/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cheftako, kaivalya97

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• staging/src/k8s.io/legacy-cloud-providers/gce/OWNERS [cheftako]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[kaivalya97]

/retest