New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SchedulerVolumeBinder: don't modify assumed pod in AssumePodVolumes #91294
SchedulerVolumeBinder: don't modify assumed pod in AssumePodVolumes #91294
Conversation
/priority backlog |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cofyc The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/test pull-kubernetes-node-e2e |
/lgtm |
/retest Review the full test history for this PR. Silence the bot with an |
1 similar comment
/retest Review the full test history for this PR. Silence the bot with an |
What type of PR is this?
What this PR does / why we need it:
It seems not necessary right now and we don't use
Spec.NodeName
inAssumePodVolumes
method.Scheduler.assume
will setSpec.NodeName
toSuggestedHost
later in the same scheduling cycle.kubernetes/pkg/scheduler/scheduler.go
Lines 583 to 591 in 7ba332a
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?:
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: