Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check container against nil before de-referencing #2552

Merged
merged 1 commit into from May 21, 2020
Merged

Check container against nil before de-referencing #2552

merged 1 commit into from May 21, 2020

Conversation

tedyu
Copy link
Collaborator

@tedyu tedyu commented May 21, 2020

This PR adds nil check in manager#getSubcontainers() so that we don't dereference nil container.

Fixes kubernetes/kubernetes#91323

@tedyu
Check container against nil before de-referencing
1ae6987 
Signed-off-by: Ted Yu <yuzhihong@gmail.com>
@tedyu
Copy link
Collaborator Author

tedyu commented May 21, 2020

/cc @dashpole

dashpole
dashpole approved these changes May 21, 2020
View reviewed changes
Copy link
Collaborator

@dashpole dashpole left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@dashpole dashpole merged commit 425e211 into google:master May 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dashpole dashpole dashpole approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Intermittent restart of Kubelet on worker node
2 participants
@tedyu @dashpole