Check for GCE finalizer in GetLoadBalancer. #91392
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
release-note-none
|
/sig network |
k8s-ci-robot
added
area/cloudprovider
sig/cloud-provider
|
/assign @MrHohn |
MrHohn
approved these changes
May 26, 2020
| @@ -317,10 +319,12 @@ func (g *Cloud) ensureInternalLoadBalancerDeleted(clusterName, clusterID string, | |||
|
|
|||
| // Try deleting instance groups - expect ResourceInuse error if needed by other LBs | |||
| igName := makeInstanceGroupName(clusterID) | |||
| klog.V(2).Infof("ensureInternalLoadBalancerDeleted(%v): attempting delete of instanceGroup %v", loadBalancerName, igName) | |||
| require.NoError(t, err) | ||
| if hasFinalizer(svc, ILBFinalizerV1) { | ||
| t.Errorf("Finalizer '%s' not deleted from service - %v", ILBFinalizerV1, svc.Finalizers) | ||
| } |
There was a problem hiding this comment.
For completeness, could we trigger GetLoadBalancer() one more time to make sure it return exists=false?
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: MrHohn, prameshj The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
skmatti
approved these changes
May 26, 2020
This is a more accurate check that looking for the forwarding rule, which could be deleted if delete flow was partially complete and abrupted by an upgrade, or if deleted by user manually. Added unit test. Addressed review comments.
k8s-ci-robot
added
the
lgtm
k8s-ci-robot
added a commit
that referenced
this pull request
May 30, 2020
…92-upstream-release-1.18 Automated cherry pick of #91392: Check for GCE finalizer in GetLoadBalancer.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What this PR does / why we need it:
This PR checks for GCE finalizer in GetLoadBalancer. This is a more accurate check that looking for the forwarding rule, which could be
deleted if delete flow was partially complete and abrupted by an upgrade, or if deleted by the user manually. GetLoadBalancer call is used to determine if LoadBalancer needs cleanup.
Added unit test.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?:
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: