Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add method for async deletion in vmss client without waiting on future #91398

Merged
merged 1 commit into from May 26, 2020
Merged

add method for async deletion in vmss client without waiting on future #91398

merged 1 commit into from May 26, 2020

Conversation

marwanad
Copy link
Member

@marwanad marwanad commented May 25, 2020 •
edited

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespace from that line:

/kind api-change
/kind bug
/kind cleanup
/kind deprecation
/kind design
/kind documentation
/kind failing-test
/kind feature
/kind flake

/kind feature

What this PR does / why we need it:

Supports deleting VMSS instances without waiting on the asynchronous future. This is needed for autoscaler since certain node deletion paths assume non-blocking operations or else the main loop will hang.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

/area provider/azure
/sig cloud-provider
/priority important-soon

@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. area/provider/azure Issues or PRs related to azure provider sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. release-note-none Denotes a PR that doesn't merit a release note. area/cloudprovider area/dependency Issues or PRs related to dependency changes and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels May 25, 2020
@k8s-ci-robot k8s-ci-robot requested review from dims, karataliu and a team May 25, 2020 00:38
@marwanad marwanad force-pushed the implement-async-deletes branch 2 times, most recently from 261ca2c to 0276396 Compare May 25, 2020 00:41
@marwanad
Copy link
Member Author

/assign @feiskyer

@feiskyer feiskyer added this to In progress in Provider Azure via automation May 25, 2020
@feiskyer
Copy link
Member 

Errors from staticcheck:
vendor/k8s.io/legacy-cloud-providers/azure/clients/vmssclient/azure_vmssclient_test.go:209:2: this value of future is never used (SA4006)

Please review the above warnings. You can test via:
  hack/verify-staticcheck.sh <failing package>
If the above warnings do not make sense, you can exempt the line or file. See:
  https://staticcheck.io/docs/#ignoring-problems

feiskyer
feiskyer reviewed May 25, 2020
View reviewed changes
Copy link
Member

@feiskyer feiskyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 25, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: feiskyer, marwanad

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 25, 2020
@feiskyer
Copy link
Member

wait a while for tests run
/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 25, 2020
@cblecker cblecker removed the request for review from a team May 25, 2020 04:17
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 25, 2020
@marwanad
Copy link
Member Author

/retest

@feiskyer
Copy link
Member

/lgtm
/hold cancel
/retest

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. and removed do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels May 25, 2020
@marwanad
Copy link
Member Author

/retest

@k8s-ci-robot k8s-ci-robot merged commit 1582077 into kubernetes:master May 26, 2020
Provider Azure automation moved this from In progress to Done May 26, 2020
@k8s-ci-robot k8s-ci-robot added this to the v1.19 milestone May 26, 2020
@dims
Copy link
Member

dims commented Aug 23, 2022

test ... ignore me!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@feiskyer feiskyer feiskyer left review comments

@dims dims Awaiting requested review from dims

@karataliu karataliu Awaiting requested review from karataliu

Assignees

@feiskyer feiskyer

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/cloudprovider area/dependency Issues or PRs related to dependency changes area/provider/azure Issues or PRs related to azure provider cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note-none Denotes a PR that doesn't merit a release note. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
Provider Azure
  
Done
Milestone
v1.19
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@marwanad @feiskyer @k8s-ci-robot @dims