Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add --logging-format flag for kube-apiserver #91501

Merged
merged 1 commit into from Jul 3, 2020
Merged

Add --logging-format flag for kube-apiserver #91501

merged 1 commit into from Jul 3, 2020

Conversation

tahsinrahman
Copy link
Contributor

/kind feature

What this PR does / why we need it:
Ref: kubernetes/enhancements#1602

NONE

/assign @serathius

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/feature Categorizes issue or PR as related to a new feature. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels May 27, 2020
@k8s-ci-robot
Copy link
Contributor

Hi @tahsinrahman. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. area/apiserver sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels May 27, 2020
serathius
serathius reviewed May 27, 2020
View reviewed changes
cmd/kube-apiserver/app/options/options.go Outdated
@@ -149,6 +152,7 @@ func (s *ServerRunOptions) Flags() (fss cliflag.NamedFlagSets) {
s.EgressSelector.AddFlags(fss.FlagSet("egress selector"))
s.Admission.AddFlags(fss.FlagSet("admission"))
s.Metrics.AddFlags(fss.FlagSet("metrics"))
s.Logs.AddFlags(fss.FlagSet("logging-format"))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
s.Logs.AddFlags(fss.FlagSet("logging-format"))
s.Logs.AddFlags(fss.FlagSet("logs"))

We register a flag group for logs, maybe list of flags will grow in future.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks! updated!

@serathius
Copy link
Contributor

One nit, else looks good!
Thanks for contributing

@serathius serathius mentioned this pull request May 27, 2020
Open
39 tasks
@serathius
Copy link
Contributor

/assign @lavalamp

@lavalamp
Copy link
Member

/ok-to-test

Is this where the flag is defined? https://github.com/kubernetes/component-base/blob/master/logs/options.go#L53

If so, that needs some work before we can add it to apiserver. Specifically, the help message needs to explain what the flag does, and what the options are.

Also is "text" the only option? I would prefer to not install the flag until there's additional options.

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels May 27, 2020
@serathius
Copy link
Contributor

@tahsinrahman please run ./hack/update-bazel.sh

@lavalamp Although this flag currently allows only "text" option, it allows for registering additional formats by registering own implementation, making logging in k8s much more customizable. I don't think we should be blocking on implementing additional formats as they will largely delay KEP implementation.

@lavalamp
Copy link
Member

Who can register additional formats? End users? Or we, the k8s authors? If the latter I think it makes more sense to install the flag when we add a second option. I don't think that will change the time at which users get value for this, and it won't leave a confusing intermediate state.

@tahsinrahman
Copy link
Contributor Author

/retest

@cheftako cheftako mentioned this pull request May 29, 2020
Merged
@serathius
Copy link
Contributor

Json format was added. #91490
PR to update help listing available options is in flight. #92177

I think we can proceed with this PR. @lavalamp PTAL

@serathius
Copy link
Contributor

/retest

1 similar comment
@serathius
Copy link
Contributor

/retest

@lavalamp
Copy link
Member

lavalamp commented Jun 16, 2020 via email

@serathius
Copy link
Contributor

serathius commented Jun 20, 2020 •
edited

PR updating flag was merged. Can go move forward with this one? @lavalamp

@serathius serathius mentioned this pull request Jun 29, 2020
Merged
@serathius
Copy link
Contributor

/milestone v1.19

@k8s-ci-robot k8s-ci-robot added this to the v1.19 milestone Jul 1, 2020
@serathius
Copy link
Contributor

Looks like US people are on holiday. @wojtek-t can you take a look?

@serathius
Copy link
Contributor

/priority important-soon

@k8s-ci-robot k8s-ci-robot added priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. and removed needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Jul 2, 2020
@serathius
Copy link
Contributor

Hey @sttts Can you take a look? Other approves are on holidays.

@sttts
Copy link
Contributor

sttts commented Jul 3, 2020

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 3, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sttts, tahsinrahman

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 3, 2020
@serathius
Copy link
Contributor

/retest

6 similar comments
@serathius
Copy link
Contributor

/retest

@serathius
Copy link
Contributor

/retest

@serathius
Copy link
Contributor

/retest

@serathius
Copy link
Contributor

/retest

@serathius
Copy link
Contributor

/retest

@serathius
Copy link
Contributor

/retest

@k8s-ci-robot k8s-ci-robot merged commit 8ec5747 into kubernetes:master Jul 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@serathius serathius serathius left review comments

@liggitt liggitt Awaiting requested review from liggitt

@wojtek-t wojtek-t Awaiting requested review from wojtek-t

Assignees

@lavalamp lavalamp

@sttts sttts

@serathius serathius

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/apiserver cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note-none Denotes a PR that doesn't merit a release note. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v1.19
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@tahsinrahman @k8s-ci-robot @serathius @lavalamp @sttts