Add '--logging-format' flag to kube-scheduler

[SataQiu]

What type of PR is this?
/kind feature

What this PR does / why we need it:
Add --logging-format flag to kube-scheduler

Which issue(s) this PR fixes:

Ref kubernetes/enhancements#1602

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

kube-scheduler: add '--logging-format' flag to support structured logging

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

NONE

[SataQiu]

/cc @serathius

[serathius]

/lgtm
/approve
/assign @ahg-g

[serathius]

/retest

[ahg-g]

did you manually test that the flag now exist and takes an effect when set?

[cheftako]

/assign @lavalamp

[lavalamp]

Like I said in the apiserver PR, I think we should wait on installing the flags until they have more than one option.

[serathius]

/retest

[serathius]

Json format was added. #91490
PR to update help listing available options is in flight. #92177

I think we can proceed with this PR. @lavalamp PTAL

[serathius]

PR updating flag was merged. Can go move forward with this one? @lavalamp

@SataQiu Please fix conflict

[liggitt]

I mostly want to make sure we don't open ourselves up to confused use of --log-file=foo.log --logging-format=json in a way which 1) doesn't work and 2) will change behavior in the future

[serathius]

@liggitt Flag validation was implemented, I tested it manually #92394 (comment)

kubernetes $ bazel run //cmd/kube-scheduler:kube-scheduler -- --logging-format=json --logtostderr=false
INFO: Analyzed target //cmd/kube-scheduler:kube-scheduler (0 packages loaded, 0 targets configured).
INFO: Found 1 target...
Target //cmd/kube-scheduler:kube-scheduler up-to-date:
  bazel-bin/cmd/kube-scheduler/linux_amd64_pure_stripped/kube-scheduler
INFO: Elapsed time: 0.440s, Critical Path: 0.21s
INFO: 0 processes.
INFO: Build completed successfully, 1 total action
INFO: Build completed successfully, 1 total action
I0701 09:22:18.180872 2515079 registry.go:173] Registering SelectorSpread plugin
I0701 09:22:18.180918 2515079 registry.go:173] Registering SelectorSpread plugin
non-default logging format doesn't honor flag: logtostderr

@lavalamp are we ok to move forward?

[serathius]

@lavalamp is OOO till Jul 6, this is to close to code freeze (Jul 9).
@liggitt could you approve?

[serathius]

/milestone v1.19

[serathius]

/lgtm
ping @ahg-g for approval of options_test.go

[serathius]

/unhold
As validation was implemented

[serathius]

/retest

[SataQiu]

Could you have a look here? thx~ @ahg-g

[ahg-g]

/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahg-g, SataQiu, serathius

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• cmd/kube-scheduler/OWNERS [ahg-g]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[serathius]

/retest

[serathius]

/retest

[serathius]

/retest

[fejta-bot]

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.