Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Scheduler PostFilter API #91547

Merged
merged 2 commits into from May 30, 2020
Merged

Scheduler PostFilter API #91547

merged 2 commits into from May 30, 2020

Conversation

Huang-Wei
Copy link
Member

What type of PR is this?

/kind api-change
/kind feature
/sig scheduling

What this PR does / why we need it:

This PR introduced type PostFilter to scheduler component config API on version v1beta1.

Which issue(s) this PR fixes:

Part of #91038.

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

`PostFilter` type is added to scheduler component config API on version v1beta1.

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API kind/feature Categorizes issue or PR as related to a new feature. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels May 28, 2020
@Huang-Wei
Copy link
Member Author

/assign @lavalamp

cc/ @damemi @ahg-g @alculquicondor

@Huang-Wei
Copy link
Member Author

/retest

This was referenced May 28, 2020
Merged
Closed
Closed
@fejta-bot
Copy link

This PR may require API review.

If so, when the changes are ready, complete the pre-review checklist and request an API review.

Status of requested reviews is tracked in the API Review project.

@alculquicondor
Copy link
Member

/lgtm

from sig-scheduling

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 29, 2020
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 29, 2020
damemi
damemi approved these changes May 29, 2020
View reviewed changes
Copy link
Contributor

@damemi damemi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 29, 2020
@ahg-g
Copy link
Member

ahg-g commented May 29, 2020

/lgtm

@damemi
Copy link
Contributor

damemi commented May 29, 2020

/retest

@Huang-Wei
Copy link
Member Author

Friendly ping @lavalamp . It's a pure field addition to existing v1beta1 API, should be easy to review.

@Huang-Wei
Copy link
Member Author

/retest

@lavalamp
Copy link
Member

/approve

In case you want to fix the nit:
/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 29, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Huang-Wei, lavalamp

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 29, 2020
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 30, 2020
@ahg-g
Copy link
Member

ahg-g commented May 30, 2020

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 30, 2020
@Huang-Wei
Copy link
Member Author

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 30, 2020
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented May 30, 2020 •
edited

@Huang-Wei: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
pull-kubernetes-e2e-kind-ipv6 8478c19 link /test pull-kubernetes-e2e-kind-ipv6

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@Huang-Wei
Copy link
Member Author

/retest

@k8s-ci-robot k8s-ci-robot merged commit 6a526e8 into kubernetes:master May 30, 2020
@k8s-ci-robot k8s-ci-robot added this to the v1.19 milestone May 30, 2020
@Huang-Wei Huang-Wei deleted the postfilter-api branch May 30, 2020 05:28
@github-actions github-actions bot mentioned this pull request Jun 2, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lavalamp lavalamp lavalamp left review comments

@ahg-g ahg-g ahg-g left review comments

@damemi damemi damemi approved these changes

Assignees

@lavalamp lavalamp

@alculquicondor alculquicondor

@damemi damemi

@ahg-g ahg-g

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v1.19
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@Huang-Wei @fejta-bot @alculquicondor @ahg-g @damemi @lavalamp @k8s-ci-robot