New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CSI Attacher tests fail to work with VolumeAttachments informers #91784
Comments
/assign @misterikkit |
Issues go stale after 90d of inactivity. If this issue is safe to close now please do so with Send feedback to sig-testing, kubernetes/test-infra and/or fejta. |
Stale issues rot after 30d of inactivity. If this issue is safe to close now please do so with Send feedback to sig-testing, kubernetes/test-infra and/or fejta. |
/remove-lifecycle rotten |
Issues go stale after 90d of inactivity. If this issue is safe to close now please do so with Send feedback to sig-testing, kubernetes/test-infra and/or fejta. |
After PR #97499, this issue doesn't seem to be relevant. Closing it for now. We can reopen if needed. |
What happened:
In the PR#91307, the csi-attacher tests failed when setup with VolumeAttachement informers
What you expected to happen:
Tests should have succeeded (please see the analysis below)
How to reproduce it (as minimally and precisely as possible):
After PR#91307, in
csi_attacher_test.go
, add VolumeAttachment informer while setting up the fake host throughNewFakeVolumeHostWithCSINodeName
()Anything else we need to know?:
Analysis/rootcause: The tests fail with timeout in
Attach()
waiting for an event in theFakeWatcher
. The priliminary analysis shows, when the informer is setup, theAttach
() is stuck on the watcher/channel before timing out. Suspected the informer may be reading the same channel that the Attach() is waiting on: verified this theory by writing the same event 2 times into the channel. This time the Attach() succeeded and so the tests.note: In particular, the
TestAttacherWithCSIDriver()
fails because this test waits for the Attach() to complete. Many other tests do not wait for Attach() completion./sig storage
CC @msau42
Environment:
kubectl version
):cat /etc/os-release
):uname -a
):The text was updated successfully, but these errors were encountered: