Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CSI Attacher tests fail to work with VolumeAttachments informers #91784

Closed
yuga711 opened this issue Jun 4, 2020 · 6 comments
Closed

CSI Attacher tests fail to work with VolumeAttachments informers #91784

yuga711 opened this issue Jun 4, 2020 · 6 comments
Assignees
Labels
kind/bug Categorizes issue or PR as related to a bug. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. sig/storage Categorizes an issue or PR as relevant to SIG Storage.

Comments

@yuga711
Copy link
Contributor

yuga711 commented Jun 4, 2020

What happened:
In the PR#91307, the csi-attacher tests failed when setup with VolumeAttachement informers

What you expected to happen:
Tests should have succeeded (please see the analysis below)

How to reproduce it (as minimally and precisely as possible):
After PR#91307, in csi_attacher_test.go, add VolumeAttachment informer while setting up the fake host through NewFakeVolumeHostWithCSINodeName()

Anything else we need to know?:
Analysis/rootcause: The tests fail with timeout in Attach() waiting for an event in the FakeWatcher. The priliminary analysis shows, when the informer is setup, the Attach() is stuck on the watcher/channel before timing out. Suspected the informer may be reading the same channel that the Attach() is waiting on: verified this theory by writing the same event 2 times into the channel. This time the Attach() succeeded and so the tests.

note: In particular, the TestAttacherWithCSIDriver() fails because this test waits for the Attach() to complete. Many other tests do not wait for Attach() completion.

/sig storage
CC @msau42

Environment:

  • Kubernetes version (use kubectl version):
  • Cloud provider or hardware configuration:
  • OS (e.g: cat /etc/os-release):
  • Kernel (e.g. uname -a):
  • Install tools:
  • Network plugin and version (if this is a network-related bug):
  • Others:
@yuga711 yuga711 added the kind/bug Categorizes issue or PR as related to a bug. label Jun 4, 2020
@k8s-ci-robot k8s-ci-robot added the needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. label Jun 4, 2020
@liggitt liggitt added the sig/storage Categorizes an issue or PR as relevant to SIG Storage. label Jun 4, 2020
@k8s-ci-robot k8s-ci-robot removed the needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. label Jun 4, 2020
@msau42
Copy link
Member

msau42 commented Jun 10, 2020

/assign @misterikkit

@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Sep 8, 2020
@fejta-bot
Copy link

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle rotten

@k8s-ci-robot k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Oct 8, 2020
@msau42
Copy link
Member

msau42 commented Oct 8, 2020

/remove-lifecycle rotten

@k8s-ci-robot k8s-ci-robot removed the lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. label Oct 8, 2020
@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jan 7, 2021
@yuga711
Copy link
Contributor Author

yuga711 commented Jan 7, 2021

After PR #97499, this issue doesn't seem to be relevant. Closing it for now. We can reopen if needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. sig/storage Categorizes an issue or PR as relevant to SIG Storage.
Projects
None yet
Development

No branches or pull requests

6 participants