Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

scheduler: run Unreserve if Reserve fails #92391

Merged
merged 1 commit into from
Jun 27, 2020
Merged

scheduler: run Unreserve if Reserve fails #92391

merged 1 commit into from
Jun 27, 2020

Conversation

adtac
Copy link
Member

@adtac adtac commented Jun 22, 2020 •
edited

What type of PR is this:

/kind bug

What this PR does / why we need it:

If a reserve plugin's Reserve method returns an error, there could be
previously allocated resources from successfully completed reserve
plugins that must be unallocated by the corresponding Unreserve
operation. Since Unreserve operations are idempotent, this patch runs
the Unreserve operation of ALL reserve plugins when a Reserve operation
fails.

Which issue(s) this PR fixes:

Replaces #83557

Special notes for your reviewer:

This depends on #92200 - if you'd like to review before that is merged, please only look at the commit 5994319

Does this PR introduce a user-facing change?:

Reserve plugins that fail to reserve will trigger the unreserve extension point

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/bug Categorizes issue or PR as related to a bug. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Jun 22, 2020
@k8s-ci-robot
Copy link
Contributor

Hi @adtac. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. area/test labels Jun 22, 2020
@k8s-ci-robot k8s-ci-robot added kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. sig/testing Categorizes an issue or PR as relevant to SIG Testing. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Jun 22, 2020
@adtac
Copy link
Member Author

adtac commented Jun 22, 2020 •
edited

/cc @alculquicondor @ahg-g (this PR is based on #92200 - see only 5994319 for the actual changes made in this PR). Will rebase onto latest master after #92200 is merged.

@adtac
Copy link
Member Author

adtac commented Jun 22, 2020

/cc @mrkm4ntr, who implemented the original version of this change in #83557

@fejta-bot
Copy link

This PR may require API review.

If so, when the changes are ready, complete the pre-review checklist and request an API review.

Status of requested reviews is tracked in the API Review project.

@adtac adtac mentioned this pull request Jun 24, 2020
Closed
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 24, 2020
@adtac adtac mentioned this pull request Jun 24, 2020
Merged
@alculquicondor
Copy link
Member

Please rebase and squash

@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Jun 26, 2020
@adtac
Copy link
Member Author

adtac commented Jun 26, 2020

Done.

@alculquicondor
Copy link
Member

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jun 26, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adtac, alculquicondor

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 26, 2020
@k8s-ci-robot k8s-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jun 26, 2020
scheduler: run Unreserve if Reserve fails
1b223b8 
If a reserve plugin's Reserve method returns an error, there could be
previously allocated resources from successfully completed reserve
plugins that must be unallocated by the corresponding Unreserve
operation. Since Unreserve operations are idempotent, this patch runs
the Unreserve operation of ALL reserve plugins when a Reserve operation
fails.
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Jun 26, 2020
@adtac
Copy link
Member Author

adtac commented Jun 26, 2020

Squashed.

@alculquicondor
Copy link
Member

/lgtm

/hold
for @mrkm4ntr. Feel free to unhold when we are closer to code freeze in case of no answer.

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 26, 2020
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 26, 2020
@alculquicondor
Copy link
Member

/retest

mrkm4ntr
mrkm4ntr approved these changes Jun 26, 2020
View reviewed changes
Copy link
Contributor

@mrkm4ntr mrkm4ntr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm
/unhold

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 26, 2020
@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

3 similar comments
@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Jun 27, 2020 •
edited

@adtac: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
pull-kubernetes-cross 32e9bd6a70449fe9fe900875cce51c5762e28157 link /test pull-kubernetes-cross
pull-kubernetes-e2e-gce-alpha-features 32e9bd6a70449fe9fe900875cce51c5762e28157 link /test pull-kubernetes-e2e-gce-alpha-features
pull-kubernetes-e2e-gce-storage-snapshot 32e9bd6a70449fe9fe900875cce51c5762e28157 link /test pull-kubernetes-e2e-gce-storage-snapshot
pull-kubernetes-e2e-azure-file-windows 32e9bd6a70449fe9fe900875cce51c5762e28157 link /test pull-kubernetes-e2e-azure-file-windows
pull-kubernetes-e2e-gce-csi-serial 32e9bd6a70449fe9fe900875cce51c5762e28157 link /test pull-kubernetes-e2e-gce-csi-serial
pull-kubernetes-e2e-azure-disk-windows 32e9bd6a70449fe9fe900875cce51c5762e28157 link /test pull-kubernetes-e2e-azure-disk-windows
pull-kubernetes-e2e-gce-storage-slow 32e9bd6a70449fe9fe900875cce51c5762e28157 link /test pull-kubernetes-e2e-gce-storage-slow

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@k8s-ci-robot k8s-ci-robot merged commit 4fc5c1e into kubernetes:master Jun 27, 2020
@k8s-ci-robot k8s-ci-robot added this to the v1.19 milestone Jun 27, 2020
@github-actions github-actions bot mentioned this pull request Jun 30, 2020
Open
@adtac adtac mentioned this pull request Sep 22, 2020
Closed
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alculquicondor alculquicondor alculquicondor left review comments

@mrkm4ntr mrkm4ntr mrkm4ntr approved these changes

@damemi damemi Awaiting requested review from damemi

@Huang-Wei Huang-Wei Awaiting requested review from Huang-Wei

Assignees

@alculquicondor alculquicondor

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v1.19
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@adtac @k8s-ci-robot @fejta-bot @alculquicondor @mrkm4ntr