Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dump conntrack table on e2e conntrack failures #92423

Merged
merged 1 commit into from
Jun 26, 2020
Merged

dump conntrack table on e2e conntrack failures #92423

merged 1 commit into from
Jun 26, 2020

Conversation

aojea
Copy link
Member

@aojea aojea commented Jun 23, 2020

/kind api-change
/kind bug
/kind cleanup
/kind deprecation
/kind design
/kind documentation
/kind failing-test
/kind feature

/kind flake

What this PR does / why we need it:

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/flake Categorizes issue or PR as related to a flaky test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Jun 23, 2020
@aojea
Copy link
Member Author

aojea commented Jun 23, 2020

/assign @wojtek-t @BenTheElder
/hold
Let's see if we can catch a failure and the results is the expected, :)

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 23, 2020
@k8s-ci-robot k8s-ci-robot added area/test sig/network Categorizes an issue or PR as relevant to SIG Network. sig/testing Categorizes an issue or PR as relevant to SIG Testing. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Jun 23, 2020
wojtek-t
wojtek-t reviewed Jun 23, 2020
View reviewed changes
test/e2e/network/conntrack.go Outdated Show resolved Hide resolved
test/e2e/network/conntrack.go Outdated Show resolved Hide resolved
@aojea
Copy link
Member Author

aojea commented Jun 23, 2020

/test pull-kubernetes-e2e-gce
/test pull-kubernetes-e2e-gce-ubuntu-containerd
/test pull-kubernetes-e2e-kind
/test pull-kubernetes-e2e-kind-ipv6

@aojea
Copy link
Member Author

aojea commented Jun 23, 2020

/retest
/test pull-kubernetes-e2e-gce
/test pull-kubernetes-e2e-gce-ubuntu-containerd
/test pull-kubernetes-e2e-kind
/test pull-kubernetes-e2e-kind-ipv6

@wojtek-t
Copy link
Member

/test pull-kubernetes-e2e-gce
/test pull-kubernetes-e2e-gce-ubuntu-containerd
/test pull-kubernetes-e2e-kind
/test pull-kubernetes-e2e-kind-ipv6

5 similar comments
@wojtek-t
Copy link
Member

/test pull-kubernetes-e2e-gce
/test pull-kubernetes-e2e-gce-ubuntu-containerd
/test pull-kubernetes-e2e-kind
/test pull-kubernetes-e2e-kind-ipv6

@aojea
Copy link
Member Author

aojea commented Jun 24, 2020

/test pull-kubernetes-e2e-gce
/test pull-kubernetes-e2e-gce-ubuntu-containerd
/test pull-kubernetes-e2e-kind
/test pull-kubernetes-e2e-kind-ipv6

@aojea
Copy link
Member Author

aojea commented Jun 24, 2020

/test pull-kubernetes-e2e-gce
/test pull-kubernetes-e2e-gce-ubuntu-containerd
/test pull-kubernetes-e2e-kind
/test pull-kubernetes-e2e-kind-ipv6

@aojea
Copy link
Member Author

aojea commented Jun 24, 2020

/test pull-kubernetes-e2e-gce
/test pull-kubernetes-e2e-gce-ubuntu-containerd
/test pull-kubernetes-e2e-kind
/test pull-kubernetes-e2e-kind-ipv6

@aojea
Copy link
Member Author

aojea commented Jun 24, 2020

/test pull-kubernetes-e2e-gce
/test pull-kubernetes-e2e-gce-ubuntu-containerd
/test pull-kubernetes-e2e-kind
/test pull-kubernetes-e2e-kind-ipv6

@aojea
Copy link
Member Author

aojea commented Jun 25, 2020

so, it does not want to fail now 🤣

/test pull-kubernetes-e2e-gce
/test pull-kubernetes-e2e-gce-ubuntu-containerd
/test pull-kubernetes-e2e-kind
/test pull-kubernetes-e2e-kind-ipv6

@aojea
Copy link
Member Author

aojea commented Jun 25, 2020

/test pull-kubernetes-e2e-gce
/test pull-kubernetes-e2e-gce-ubuntu-containerd
/test pull-kubernetes-e2e-kind
/test pull-kubernetes-e2e-kind-ipv6

@aojea aojea mentioned this pull request Jun 25, 2020
Closed
@aojea
Copy link
Member Author

aojea commented Jun 25, 2020

/test pull-kubernetes-e2e-gce
/test pull-kubernetes-e2e-gce-ubuntu-containerd
/test pull-kubernetes-e2e-kind
/test pull-kubernetes-e2e-kind-ipv6

1 similar comment
@aojea
Copy link
Member Author

aojea commented Jun 25, 2020

/test pull-kubernetes-e2e-gce
/test pull-kubernetes-e2e-gce-ubuntu-containerd
/test pull-kubernetes-e2e-kind
/test pull-kubernetes-e2e-kind-ipv6

@aojea
Copy link
Member Author

aojea commented Jun 25, 2020

/test pull-kubernetes-e2e-gce
/test pull-kubernetes-e2e-gce-ubuntu-containerd
/test pull-kubernetes-e2e-kind
/test pull-kubernetes-e2e-kind-ipv6

@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jun 26, 2020
wojtek-t
wojtek-t reviewed Jun 26, 2020
View reviewed changes
test/e2e/network/conntrack.go Outdated Show resolved Hide resolved
test/e2e/network/conntrack.go Outdated Show resolved Hide resolved
aojea
aojea commented Jun 26, 2020
View reviewed changes
test/e2e/network/conntrack.go Outdated Show resolved Hide resolved
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jun 26, 2020
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jun 26, 2020
@aojea
Copy link
Member Author

aojea commented Jun 26, 2020

/hold cancel
/cc @bowei

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 26, 2020
@k8s-ci-robot k8s-ci-robot requested a review from bowei June 26, 2020 10:54
wojtek-t
wojtek-t reviewed Jun 26, 2020
View reviewed changes
Copy link
Member

@wojtek-t wojtek-t left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

test/e2e/network/conntrack.go Outdated Show resolved Hide resolved
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aojea, wojtek-t

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 26, 2020
@aojea
dump conntrack table on e2e conntrack failures
0ef7f27 
Signed-off-by: Antonio Ojea <antonio.ojea.garcia@gmail.com>
@wojtek-t
Copy link
Member

/lgtm

[Assuming test won't fail]

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 26, 2020
@aojea
Copy link
Member Author

aojea commented Jun 26, 2020

/retest

@k8s-ci-robot k8s-ci-robot merged commit c90427d into kubernetes:master Jun 26, 2020
@k8s-ci-robot k8s-ci-robot added this to the v1.19 milestone Jun 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wojtek-t wojtek-t wojtek-t left review comments

@andrewsykim andrewsykim Awaiting requested review from andrewsykim

@nicksardo nicksardo Awaiting requested review from nicksardo

@bowei bowei Awaiting requested review from bowei

Assignees

@BenTheElder BenTheElder

@wojtek-t wojtek-t

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/flake Categorizes issue or PR as related to a flaky test. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. release-note-none Denotes a PR that doesn't merit a release note. sig/network Categorizes an issue or PR as relevant to SIG Network. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
v1.19
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@aojea @wojtek-t @k8s-ci-robot @BenTheElder