-
Notifications
You must be signed in to change notification settings - Fork 38.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix pkg/volume/vspherevolume static check #92462
fix pkg/volume/vspherevolume static check #92462
Conversation
Hi @Haleygo. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test |
Can you also remove these fields from hack/.staticcheck_failures? |
remove field from staticcheck_failures
e78b15d
to
a5b7ce1
Compare
Sorry I missed that! Done. |
/lgtm |
/assign @BenTheElder |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: BenTheElder, Haleygo, msau42 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest Review the full test history for this PR. Silence the bot with an |
/kind cleanup |
What type of PR is this?
/kind cleanup
What this PR does / why we need it: Cleanup pkg/volume/vsphere_volume static check errors.
Which issue(s) this PR fixes:
Part of #92402
Special notes for your reviewer:
Does this PR introduce a user-facing change?:
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: