Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump etcd revision after changes to migrate script #92498

Merged
merged 1 commit into from
Jun 25, 2020
Merged

Bump etcd revision after changes to migrate script #92498

merged 1 commit into from
Jun 25, 2020

Conversation

wojtek-t
Copy link
Member

Ref #92286

NONE

/kind bug

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/bug Categorizes issue or PR as related to a bug. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Jun 25, 2020
@wojtek-t wojtek-t mentioned this pull request Jun 25, 2020
Merged
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 25, 2020
@k8s-ci-robot k8s-ci-robot added area/release-eng Issues or PRs related to the Release Engineering subproject sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Jun 25, 2020
@BenTheElder
Copy link
Member

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 25, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: BenTheElder, wojtek-t

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@wojtek-t
Copy link
Member Author

/retest

2 similar comments
@wojtek-t
Copy link
Member Author

/retest

@wojtek-t
Copy link
Member Author

/retest

jingyih
jingyih reviewed Jun 25, 2020
View reviewed changes
Copy link
Contributor

@jingyih jingyih left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@jingyih
Copy link
Contributor

jingyih commented Jun 25, 2020

/retest

@jingyih
Copy link
Contributor

jingyih commented Jun 25, 2020

I realized we probably should have bumped the revision as part of #92286. Any changes under cluster/images/etcd triggers a new image build and push to staging repo.

@wojtek-t
Copy link
Member Author

I realized we probably should have bumped the revision as part of #92286. Any changes under cluster/images/etcd triggers a new image build and push to staging repo.

yes - it's a follow-up exactly; sorry, I forgot about it

/retest

@BenTheElder
Copy link
Member

Because of the promotion system (by sha256) as long as the promotion PRs happen promptly / with the correct digest the "prod" registry will have the "correct" image anyhow, but we should probably keep this bumped.

@k8s-ci-robot k8s-ci-robot merged commit a8abba5 into kubernetes:master Jun 25, 2020
@k8s-ci-robot k8s-ci-robot added this to the v1.19 milestone Jun 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jingyih jingyih jingyih left review comments

@jpbetz jpbetz Awaiting requested review from jpbetz

@wenjiaswe wenjiaswe Awaiting requested review from wenjiaswe

Assignees

@jpbetz jpbetz

@BenTheElder BenTheElder

@jingyih jingyih

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/release-eng Issues or PRs related to the Release Engineering subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. release-note-none Denotes a PR that doesn't merit a release note. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v1.19
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@wojtek-t @BenTheElder @k8s-ci-robot @jingyih @jpbetz