-
Notifications
You must be signed in to change notification settings - Fork 38.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sets desiredcapacity instead of minsize and maxsize on ResizeInstanceGroup #92549
Conversation
Welcome @ellistarn! |
Hi @ellistarn. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/label release-note-none |
@ellistarn: The label(s) In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Looks like this runs after the test https://github.com/kubernetes/kubernetes/blob/master/test/e2e/autoscaling/autoscaling_timer.go#L78 and setting max and min to the same value prevents further scaling on that ASG. /lgtm |
/retest |
@ellistarn: Cannot trigger testing until a trusted user reviews the PR and leaves an In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test |
/retest |
Looks good, by comparing what gce does /approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ellistarn, justinsb The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
Any suggestions on unrelated flakes @nckturner? /retest |
/retest |
/retest |
1 similar comment
/retest |
/release-note-none |
What type of PR is this?
/kind bug
What this PR does / why we need it:
Currently, after the autoscaling_timer.go test (the only callsite of this function), the ASG is reset with min and max nodes. If the test is ever run again, it fails due to the ASG being unable to scale up or down. This simply resets the Desired count leaving the original min/max intact.
Which issue(s) this PR fixes:
Fixes #92548