Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support kubectl annotate --list option #92576

Merged
merged 1 commit into from
Jul 1, 2020
Merged

Support kubectl annotate --list option #92576

merged 1 commit into from
Jul 1, 2020

Conversation

zhouya0
Copy link
Contributor

@zhouya0 zhouya0 commented Jun 28, 2020

What type of PR is this?
/kind feature

What this PR does / why we need it:
Support kubectl annotate --list option which synchronizes the behavior with kubectl label --list.

Which issue(s) this PR fixes:

Fixes #92499

Special notes for your reviewer:
/cc @soltysh
/cc @brianpursley

Does this PR introduce a user-facing change?:

Support kubectl annotate --list option

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. area/kubectl sig/cli Categorizes an issue or PR as relevant to SIG CLI. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Jun 28, 2020
@zhouya0 zhouya0 force-pushed the support_kubectl_annotate_list branch 2 times, most recently from ba3bf82 to d0d8f93 Compare June 28, 2020 03:52
@zhouya0
Copy link
Contributor Author

zhouya0 commented Jun 28, 2020

/retest

@zhouya0 zhouya0 force-pushed the support_kubectl_annotate_list branch from d0d8f93 to ca1d598 Compare June 28, 2020 06:16
@zhouya0
Copy link
Contributor Author

zhouya0 commented Jun 28, 2020

/retest

brianpursley
brianpursley reviewed Jun 30, 2020
View reviewed changes
staging/src/k8s.io/kubectl/pkg/cmd/annotate/annotate.go
if err != nil {
return err
}
fmt.Fprintf(o.ErrOut, "Listing annotations for %s.%s/%s:\n", gvks[0].Kind, gvks[0].Group, info.Name)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not a huge fan of using stderr for informational messages, but I know this is the same way label --list does it.

I'll leave this up to @soltysh to comment on, but since it is done the same way in label --list, I'm fine with either leaving it this way, or fixing it in both places.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Brian is reading my mind - please change it to StdOut especially that's expected, can be done in a followup.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, Done in #92691 :)

@brianpursley
Copy link
Member

/lgtm

With one potential comment, but I would be fine if it got merged like this.

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 30, 2020
soltysh
soltysh approved these changes Jun 30, 2020
View reviewed changes
Copy link
Contributor

@soltysh soltysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm
/priority backlog
/kind bug

@k8s-ci-robot k8s-ci-robot added priority/backlog Higher priority than priority/awaiting-more-evidence. kind/bug Categorizes issue or PR as related to a bug. and removed needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. labels Jun 30, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: soltysh, zhouya0

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 30, 2020
@k8s-ci-robot k8s-ci-robot merged commit 8b9c9ea into kubernetes:master Jul 1, 2020
@k8s-ci-robot k8s-ci-robot added this to the v1.19 milestone Jul 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@soltysh soltysh soltysh approved these changes

@brianpursley brianpursley brianpursley approved these changes

Assignees

@soltysh soltysh

@brianpursley brianpursley

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/kubectl cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/backlog Higher priority than priority/awaiting-more-evidence. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/cli Categorizes an issue or PR as relevant to SIG CLI. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v1.19
Development

Successfully merging this pull request may close these issues.

kubectl annotate doesnot have --list option
4 participants
@zhouya0 @brianpursley @k8s-ci-robot @soltysh