Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change kubectl label and annotation list option stdout #92691

Merged
merged 1 commit into from Jul 2, 2020
Merged

Change kubectl label and annotation list option stdout #92691

merged 1 commit into from Jul 2, 2020

Conversation

zhouya0
Copy link
Contributor

@zhouya0 zhouya0 commented Jul 1, 2020

What type of PR is this?
/kind cleanup

What this PR does / why we need it:
As what said in https://github.com/kubernetes/kubernetes/pull/92576/files#r447859434.
The message is expected and should not be used is stdErr.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:
/cc @soltysh

Does this PR introduce a user-facing change?:

None

@k8s-ci-robot k8s-ci-robot requested a review from soltysh July 1, 2020 09:03
@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. area/kubectl sig/cli Categorizes an issue or PR as relevant to SIG CLI. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Jul 1, 2020
@zhouya0 zhouya0 mentioned this pull request Jul 1, 2020
Merged
soltysh
soltysh approved these changes Jul 1, 2020
View reviewed changes
Copy link
Contributor

@soltysh soltysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve
/retest
/kind backlog

@k8s-ci-robot
Copy link
Contributor

@soltysh: The label(s) kind/backlog cannot be applied, because the repository doesn't have them

In response to this:

/lgtm
/approve
/retest
/kind backlog

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 1, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: soltysh, zhouya0

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 1, 2020
@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@zhouya0
Copy link
Contributor Author

zhouya0 commented Jul 2, 2020

/retest

7 similar comments
@zhouya0
Copy link
Contributor Author

zhouya0 commented Jul 2, 2020

/retest

@zhouya0
Copy link
Contributor Author

zhouya0 commented Jul 2, 2020

/retest

@zhouya0
Copy link
Contributor Author

zhouya0 commented Jul 2, 2020

/retest

@zhouya0
Copy link
Contributor Author

zhouya0 commented Jul 2, 2020

/retest

@zhouya0
Copy link
Contributor Author

zhouya0 commented Jul 2, 2020

/retest

@zhouya0
Copy link
Contributor Author

zhouya0 commented Jul 2, 2020

/retest

@zhouya0
Copy link
Contributor Author

zhouya0 commented Jul 2, 2020

/retest

@zhouya0 zhouya0 closed this Jul 2, 2020
@zhouya0 zhouya0 reopened this Jul 2, 2020
@zhouya0
Copy link
Contributor Author

zhouya0 commented Jul 2, 2020

/test pull-kubernetes-e2e-kind-ipv6

@zhouya0
Copy link
Contributor Author

zhouya0 commented Jul 2, 2020

/retest

@zhouya0 zhouya0 force-pushed the change_kubectl_list_option_stdout branch from c196002 to abad08d Compare July 2, 2020 09:48
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 2, 2020
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Jul 2, 2020 •
edited

@zhouya0: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
pull-kubernetes-e2e-kind-ipv6 c1960026a5492e5c35917d39723e28c8dcb5c5b5 link /test pull-kubernetes-e2e-kind-ipv6

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@zhouya0
Copy link
Contributor Author

zhouya0 commented Jul 2, 2020

/retest

@zhouya0
Copy link
Contributor Author

zhouya0 commented Jul 2, 2020

/cc @brianpursley Looking for a lgtm :)

@brianpursley
Copy link
Member

/lgtm

Thanks!

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 2, 2020
@k8s-ci-robot k8s-ci-robot merged commit 6cedc08 into kubernetes:master Jul 2, 2020
@k8s-ci-robot k8s-ci-robot added this to the v1.19 milestone Jul 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@soltysh soltysh soltysh approved these changes

Assignees

@soltysh soltysh

@brianpursley brianpursley

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/kubectl cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. release-note-none Denotes a PR that doesn't merit a release note. sig/cli Categorizes an issue or PR as relevant to SIG CLI. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v1.19
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@zhouya0 @k8s-ci-robot @fejta-bot @brianpursley @soltysh