Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[1.16] Cherry pick of #92644: Wait for all informers to sync in /readyz. #92695

Merged
merged 1 commit into from Jul 8, 2020
Merged

[1.16] Cherry pick of #92644: Wait for all informers to sync in /readyz. #92695

merged 1 commit into from Jul 8, 2020

Conversation

jprzychodzen
Copy link
Contributor

Cherry pick of #92644 on release-1.16.

#92644: Wait for all informers to sync in /readyz.

/cc @wojtek-t
/cc @mborsz
/cc @mm4tt

@k8s-ci-robot k8s-ci-robot added the do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. label Jul 1, 2020
@k8s-ci-robot k8s-ci-robot added this to the v1.16 milestone Jul 1, 2020
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. area/apiserver area/test sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/testing Categorizes an issue or PR as relevant to SIG Testing. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Jul 1, 2020
@jprzychodzen jprzychodzen force-pushed the automated-cherry-pick-of-#92644-origin-release-1.16 branch from b9b32cb to 9287215 Compare July 1, 2020 11:18
@jprzychodzen jprzychodzen force-pushed the automated-cherry-pick-of-#92644-origin-release-1.16 branch from 9287215 to 56f277c Compare July 1, 2020 12:44
@wojtek-t wojtek-t added the kind/bug Categorizes issue or PR as related to a bug. label Jul 1, 2020
@k8s-ci-robot k8s-ci-robot removed the needs-kind Indicates a PR lacks a `kind/foo` label and requires one. label Jul 1, 2020
@wojtek-t wojtek-t added priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. and removed needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Jul 1, 2020
@jprzychodzen
Copy link
Contributor Author

/retest

logicalhan
logicalhan reviewed Jul 2, 2020
View reviewed changes
Copy link
Member

@logicalhan logicalhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 2, 2020
@wojtek-t
Copy link
Member

wojtek-t commented Jul 3, 2020

/approve

@kubernetes/release-managers - for cherrypick approval

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jprzychodzen, wojtek-t

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 3, 2020
@jprzychodzen
Copy link
Contributor Author

@kubernetes/release-managers

@feiskyer feiskyer added cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. and removed do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. labels Jul 8, 2020
@k8s-ci-robot k8s-ci-robot merged commit 0707ac1 into kubernetes:release-1.16 Jul 8, 2020
@wojtek-t wojtek-t mentioned this pull request Aug 3, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@logicalhan logicalhan logicalhan left review comments

@mborsz mborsz Awaiting requested review from mborsz

@mm4tt mm4tt Awaiting requested review from mm4tt

@wojtek-t wojtek-t Awaiting requested review from wojtek-t

Assignees

@logicalhan logicalhan

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/apiserver area/test cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v1.16
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@jprzychodzen @wojtek-t @k8s-ci-robot @logicalhan @feiskyer @mborsz