Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mark 'kubeadm config view' command as deprecated #92740

Merged
merged 1 commit into from Jul 3, 2020
Merged

Mark 'kubeadm config view' command as deprecated #92740

merged 1 commit into from Jul 3, 2020

Conversation

SataQiu
Copy link
Member

@SataQiu SataQiu commented Jul 2, 2020 •
edited

What type of PR is this?
/kind deprecation

What this PR does / why we need it:
As we can use kubectl get cm -o yaml -n kube-system kubeadm-config to fetch the whole config of kubeadm,
we prefer to deprecate and remove this redundant command.

Which issue(s) this PR fixes:

Ref kubernetes/kubeadm#2203

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

kubeadm: `kubeadm config view` command has been deprecated and will be removed in a feature release, please use `kubectl get cm -o yaml -n kube-system kubeadm-config` to get the kubeadm config directly

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/deprecation Categorizes issue or PR as related to a feature/enhancement marked for deprecation. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Jul 2, 2020
@SataQiu
Copy link
Member Author

SataQiu commented Jul 2, 2020

/cc @rosti @neolit123

@k8s-ci-robot k8s-ci-robot added area/kubeadm sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Jul 2, 2020
neolit123
neolit123 reviewed Jul 2, 2020
View reviewed changes
Copy link
Member

@neolit123 neolit123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
thanks @SataQiu

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: neolit123, SataQiu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 2, 2020
@SataQiu SataQiu force-pushed the deprecate-config-view-20200702 branch from a7f8616 to f4fbf73 Compare July 2, 2020 15:18
@neolit123
Copy link
Member

missing "to" in the release note:

to get the kubeadm config directly

/priority backlog
/lgtm

@k8s-ci-robot k8s-ci-robot added priority/backlog Higher priority than priority/awaiting-more-evidence. and removed needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Jul 2, 2020
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 2, 2020
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 2, 2020
@SataQiu SataQiu force-pushed the deprecate-config-view-20200702 branch from f4fbf73 to 2b7af10 Compare July 3, 2020 01:40
@neolit123
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 3, 2020
@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@k8s-ci-robot k8s-ci-robot merged commit af29f81 into kubernetes:master Jul 3, 2020
@k8s-ci-robot k8s-ci-robot added this to the v1.19 milestone Jul 3, 2020
@github-actions github-actions bot mentioned this pull request Jul 8, 2020
Open
@rosti rosti mentioned this pull request Jul 29, 2020
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@neolit123 neolit123 neolit123 left review comments

@rosti rosti Awaiting requested review from rosti

@detiber detiber Awaiting requested review from detiber

@ereslibre ereslibre Awaiting requested review from ereslibre

Assignees

@neolit123 neolit123

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/kubeadm cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/deprecation Categorizes issue or PR as related to a feature/enhancement marked for deprecation. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/backlog Higher priority than priority/awaiting-more-evidence. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v1.19
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@SataQiu @k8s-ci-robot @neolit123 @fejta-bot