Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Automated cherry pick of #92584: kube-proxy ipvs masquerade hairpin traffic #92748

Merged
merged 2 commits into from Jul 10, 2020
Merged

Automated cherry pick of #92584: kube-proxy ipvs masquerade hairpin traffic #92748

merged 2 commits into from Jul 10, 2020

Conversation

aojea
Copy link
Member

@aojea aojea commented Jul 2, 2020

Cherry pick of #92584 on release-1.16.

#92584: kube-proxy ipvs masquerade hairpin traffic

For details on the cherry pick process, see the cherry pick requests page.

@aojea
kube-proxy ipvs masquerade hairpin traffic
3a65980 
Masquerade de traffic that loops back to the originator
before they hit the kubernetes-specific postrouting rules

Signed-off-by: Antonio Ojea <antonio.ojea.garcia@gmail.com>
@k8s-ci-robot k8s-ci-robot added the do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. label Jul 2, 2020
@k8s-ci-robot k8s-ci-robot added this to the v1.16 milestone Jul 2, 2020
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jul 2, 2020
@k8s-ci-robot k8s-ci-robot added area/ipvs sig/network Categorizes an issue or PR as relevant to SIG Network. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Jul 2, 2020
@aojea
Copy link
Member Author

aojea commented Jul 2, 2020

/assing @andrewsykim

@aojea
Copy link
Member Author

aojea commented Jul 2, 2020

pull-kubernetes-e2e-gci-gce-ipvs — Job failed.

only the flexvolume tests failed in the ipvs job seems is good to go

@aojea
Copy link
Member Author

aojea commented Jul 2, 2020

/hold
it's failing the 1.17 cherry-pick
#92747 (comment)

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 2, 2020
@andrewsykim
Copy link
Member

@aojea I think we need to cherry-pick these two commits to get the e2es working on this branch #89327 & #89854.

@aojea
Copy link
Member Author

aojea commented Jul 7, 2020

@aojea I think we need to cherry-pick these two commits to get the e2es working on this branch #89327 & #89854.

@andrewsykim this job is only failing the 2 flexvolumes tests, so it should be ok, but I don't think we should move forward with this until 1.17 is working

/retest

@aojea
cluster: ipvs conntrack module vs kernel version
7fa266c 
We should use 'nf_conntrack' instead of 'nf_conntrack_ipv4'
for linux kernel >= 4.19
@k8s-ci-robot k8s-ci-robot added the sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. label Jul 7, 2020
@aojea
Copy link
Member Author

aojea commented Jul 7, 2020

/hold cancel
only the flexvolume tests failed in the ipvs job, that are known to fail

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 7, 2020
andrewsykim
andrewsykim reviewed Jul 7, 2020
View reviewed changes
Copy link
Member

@andrewsykim andrewsykim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 7, 2020
@andrewsykim
Copy link
Member

/assign @spiffxp

Can you sign off on the /cluster changes here?

@spiffxp
Copy link
Member

spiffxp commented Jul 7, 2020

Just noting for myself or whomever is spelunking, though it's not clear from the title or description, #89327 got cherry picked into this

@spiffxp
Copy link
Member

spiffxp commented Jul 7, 2020

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andrewsykim, aojea, spiffxp

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 7, 2020
@feiskyer feiskyer added cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Jul 8, 2020
@feiskyer
Copy link
Member

feiskyer commented Jul 8, 2020

/retest

@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

3 similar comments
@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@aojea
Copy link
Member Author

aojea commented Jul 9, 2020

/kind bug
/priority important-soon

@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. and removed needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Jul 9, 2020
@aojea
Copy link
Member Author

aojea commented Jul 9, 2020

/retest

1 similar comment
@aojea
Copy link
Member Author

aojea commented Jul 9, 2020

/retest

@andrewsykim
Copy link
Member

@aojea seeing actual test failures here

@andrewsykim
Copy link
Member

For the session affinity tests I think you also need to backport #89854 😕

@aojea
Copy link
Member Author

aojea commented Jul 9, 2020

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 9, 2020
@spiffxp
Copy link
Member

spiffxp commented Jul 10, 2020

/retest

@aojea
Copy link
Member Author

aojea commented Jul 10, 2020

For the session affinity tests I think you also need to backport #89854

nevermind, I've added the the affinity tests checking the timeout for stickiness in a later version 😄 , only the flexvolume tests are failing

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 10, 2020
@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Jul 10, 2020 •
edited

@aojea: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
pull-kubernetes-e2e-gci-gce-ipvs 7fa266c link /test pull-kubernetes-e2e-gci-gce-ipvs

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@k8s-ci-robot k8s-ci-robot merged commit 61b06f9 into kubernetes:release-1.16 Jul 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrewsykim andrewsykim andrewsykim left review comments

@danwinship danwinship Awaiting requested review from danwinship

@rramkumar1 rramkumar1 Awaiting requested review from rramkumar1

Assignees

@spiffxp spiffxp

@andrewsykim andrewsykim

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/ipvs cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note-none Denotes a PR that doesn't merit a release note. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. sig/network Categorizes an issue or PR as relevant to SIG Network. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v1.16
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@aojea @andrewsykim @spiffxp @k8s-ci-robot @feiskyer @fejta-bot