Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix naming inconsistency in scheduler plugin interface comments #92940

Merged
merged 1 commit into from Sep 4, 2020
Merged

Fix naming inconsistency in scheduler plugin interface comments #92940

merged 1 commit into from Sep 4, 2020

Conversation

yuanchen8911
Copy link
Member

What type of PR is this?
/kind bug

What this PR does / why we need it:
Fixed the inconsistency in plugin naming in the comments of scheduler plugin interfaces.
Changed all plugin names referred to in the comments to UpperCamelCase.

Which issue(s) this PR fixes:
No

Special notes for your reviewer:
None

Does this PR introduce a user-facing change?:
No

For more information on release notes see: https://git.k8s.io/community/contributors/guide/release-notes.md
-->

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/bug Categorizes issue or PR as related to a bug. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jul 9, 2020
@yuanchen8911 yuanchen8911 changed the title Update interface.go Fixe inconsistency in plugin naming in comments of scheduler plugin interfaces Jul 9, 2020
@k8s-ci-robot k8s-ci-robot added sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Jul 9, 2020
@yuanchen8911 yuanchen8911 changed the title Fixe inconsistency in plugin naming in comments of scheduler plugin interfaces Fixe naming inconsistency in scheduler plugin interface comments Jul 9, 2020
@yuanchen8911 yuanchen8911 changed the title Fixe naming inconsistency in scheduler plugin interface comments Fix naming inconsistency in scheduler plugin interface comments Jul 9, 2020
@yuanchen8911
Copy link
Member Author

/retest

@yuanchen8911
Copy link
Member Author

No idea why the tests failed. The changes were only rewording in the comments.

@damemi
Copy link
Contributor

damemi commented Jul 9, 2020

@yuanchen8911 those failures don't look related to your change, there is a good chance they are just flakes (false negatives) in the test infra

@chendave
Copy link
Member

/retest

@damemi
Copy link
Contributor

damemi commented Jul 10, 2020

Can you please squash the commits?

@yuanchen8911
Copy link
Member Author

Can you please squash the commits?
done, thanks.

@yuanchen8911
Copy link
Member Author

Can you please squash the commits?
done, thanks.

Can you please squash the commits?

done

@yuanchen8911
Copy link
Member Author

/retest

damemi
damemi approved these changes Jul 13, 2020
View reviewed changes
Copy link
Contributor

@damemi damemi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 13, 2020
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 21, 2020
@yuanchen8911
Copy link
Member Author

/review @damemi
/review @ahg-g

damemi
damemi approved these changes Jul 24, 2020
View reviewed changes
Copy link
Contributor

@damemi damemi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@damemi
Copy link
Contributor

damemi commented Jul 24, 2020

/retest

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 24, 2020
damemi
damemi reviewed Aug 31, 2020
View reviewed changes
Copy link
Contributor

@damemi damemi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yuanchen8911 looks like you have a conflict that needs rebasing

@yuanchen8911
Copy link
Member Author

@damemi Can we merge this PR now? Thanks.

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 31, 2020
@yuanchen8911
Copy link
Member Author

@yuanchen8911 looks like you have a conflict that needs rebasing

Thanks, looking now.

@k8s-ci-robot k8s-ci-robot removed lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Aug 31, 2020
@chendave
Copy link
Member

chendave commented Sep 1, 2020

/retest

damemi
damemi approved these changes Sep 1, 2020
View reviewed changes
Copy link
Contributor

@damemi damemi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
will need someone like @ahg-g to approve. the test failures don't look related

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 1, 2020
@ahg-g
Copy link
Member

ahg-g commented Sep 1, 2020

/remove-kind bug
/kind cleanup
/priority important-longterm
/approve

@k8s-ci-robot k8s-ci-robot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. and removed kind/bug Categorizes issue or PR as related to a bug. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Sep 1, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahg-g, yuanchen8911

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 1, 2020
@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

1 similar comment
@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@wojtek-t wojtek-t added this to the v1.20 milestone Sep 4, 2020
@k8s-ci-robot k8s-ci-robot merged commit 6a9500e into kubernetes:master Sep 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@damemi damemi damemi approved these changes

@hex108 hex108 Awaiting requested review from hex108

@chendave chendave Awaiting requested review from chendave

@ahg-g ahg-g Awaiting requested review from ahg-g

Assignees

@damemi damemi

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. release-note-none Denotes a PR that doesn't merit a release note. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v1.20
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@yuanchen8911 @damemi @chendave @ahg-g @k8s-ci-robot @fejta-bot @wojtek-t