agnhost image: use actual DNS domain instead of hardcoded cluster.local #92964

vponomaryov · 2020-07-10T11:41:25Z

'agnhost' image uses hardcoded 'cluster.local' value for DNS domain.
It leads to failure of a bunch of HPA tests when test cluster is
configured to use custom DNS domain and there is no alias for
default 'cluster.local' one.
So, fix it by reusing it's own function for reading DNS domain suffixes.

Bumps 'agnhost' image version to 2.24

Signed-off-by: Valerii Ponomarov kiparis.kh@gmail.com

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespace from that line:

/kind api-change
/kind bug
/kind cleanup
/kind deprecation
/kind design
/kind documentation
/kind failing-test
/kind feature
/kind flake

What this PR does / why we need it:

Which issue(s) this PR fixes:

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

k8s-ci-robot · 2020-07-10T11:41:28Z

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.

If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
If you signed the CLA as a corporation, please sign in with your organization's credentials at https://identity.linuxfoundation.org/projects/cncf to be authorized.
If you have done the above and are still having issues with the CLA being reported as unsigned, please log a ticket with the Linux Foundation Helpdesk: https://support.linuxfoundation.org/
Should you encounter any issues with the Linux Foundation Helpdesk, send a message to the backup e-mail support address at: login-issues@jira.linuxfoundation.org

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

k8s-ci-robot · 2020-07-10T11:41:33Z

Welcome @vponomaryov!

It looks like this is your first PR to kubernetes/kubernetes 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/kubernetes has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

k8s-ci-robot · 2020-07-10T11:41:33Z

Hi @vponomaryov. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

vponomaryov · 2020-07-10T11:56:07Z

This PR fixes following issue: #88752

vponomaryov · 2020-07-10T15:14:52Z

/retest

k8s-ci-robot · 2020-07-10T15:15:07Z

@vponomaryov: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

vponomaryov · 2020-07-10T15:23:55Z

Fixes #88752

gjtempleton · 2020-07-10T15:49:05Z

/sig autoscaling

vponomaryov · 2020-07-10T17:32:58Z

/assign @claudiubelu @luxas

listx · 2020-07-15T02:03:20Z

/ok-to-test

claudiubelu · 2020-09-03T14:20:26Z

/lgtm

jtslear · 2020-09-04T11:25:01Z

/milestone v1.20

k8s-ci-robot · 2020-09-04T11:25:04Z

@jtslear: You must be a member of the kubernetes/milestone-maintainers GitHub team to set the milestone. If you believe you should be able to issue the /milestone command, please contact your and have them propose you as an additional delegate for this responsibility.

In response to this:

/milestone v1.20

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

vponomaryov · 2020-09-07T11:00:52Z

/assign @fejta

justaugustus · 2020-09-08T14:18:40Z

/milestone v1.20

vponomaryov · 2020-09-08T20:32:41Z

@justaugustus thanks for adding milestone label!
@claudiubelu , as I understood, this PR requires your "/approve" first, as owner at [1], and only then "/approve" from someone at [2].

[1] https://github.com/kubernetes/kubernetes/blob/master/test/images/agnhost/OWNERS
[2] https://github.com/kubernetes/kubernetes/blob/master/build/OWNERS

claudiubelu · 2020-09-09T11:33:13Z

Indeed, I didn't approve it since it also has changes outside of the agnhost image, so my approval wouldn't make this go in anyways.

/approve

liggitt · 2020-09-09T12:29:17Z

cc @kubernetes/sig-network-pr-reviews

liggitt · 2020-09-09T12:42:02Z

/assign @thockin

would like your $0.02 on the DNS changes here, especially w.r.t. #92964 (comment) and scraping/parsing search paths out of the resolv.conf file like this

thockin

LGTM, I just want this self-documenting

thockin · 2020-09-09T16:12:58Z

test/images/agnhost/dns/dns.go

-func getDNSSuffixList() []string {
+
+// GetDNSSuffixList reads DNS config file and returns the list of configured DNS suffixes
+func GetDNSSuffixList() []string {


FWIW using strings.Fields() would be safer WRT repeated whitespace

The only thing that is changed here is that function becomes exported having uppercase first letter. So, I do not understand the point of the comment.

exporting it and starting to use it as a utility method for other packages expands the scope of the code and increases the importance that it be robust/correct

Strictly speaking this function gets a list of "search paths" and if I were to find "" in that list (which you would if there was a double-space) I would be very surprised.

Is there a test-case for this function? I'm not going to demand you go write one, unless you want to, but it probably should have a test including values with duplicate whitespace

@liggitt , @thockin I agree that it would be good to fix this thing, but I disagree that it must be part of this particular change that has one concrete goal - fixing concrete bug. And the change you propose me doing is not related to the bugfix at all.

Then, about unit tests, the fact that I changed the name of the function and unit tests passed means that there are either no tests or they were not run. In anyway, it doesn't get tested on regular basis. So, it has much more TODOs which must be done, but definitely not as part of this change, IMHO.

thockin · 2020-09-09T16:15:24Z

test/images/agnhost/resource-consumer-controller/controller.go

 )

+func getDNSDomain() string {


Can we please get a comment explaining how this is operating and why? It's PROBABLY safe, all things considered, but it's a heuristic.

This has come up in other places, and we really ought to expose it through downward API or something like that.

Maybe it is good to have comments, but even this module has more complex functions without comments.
According to the activity on the bug-report which gets fixed here, no one really cared about it. So, I wonder exactly where it has come up?

Past mistakes do not mean we shouldn't do better. The function is sufficiently subtle that having an explanation of what it is supposed to be doing and why is justified. I'm not asking for a book, just a couple sentences. Less than this comment, probably.

Added comment in the code here and in the place of it's call.

thockin · 2020-09-09T16:17:09Z

test/images/agnhost/resource-consumer-controller/controller.go

@@ -214,7 +240,7 @@ func (c *controller) sendConsumeCustomMetric(w http.ResponseWriter, metric strin
 }

 func createConsumerURL(suffix string) string {
-	return fmt.Sprintf("http://%s.%s.svc.cluster.local:%d%s", consumerServiceName, consumerServiceNamespace, consumerPort, suffix)


WRT Windows, this is one of a long list of things that don't work right in Windows which were deemed "acceptable because no Windows user would expect them to work", even if a Kube user would. Sigh.

thockin · 2020-09-09T16:17:58Z

test/images/agnhost/agnhost.go

@@ -51,7 +51,7 @@ import (
 func main() {
 	rootCmd := &cobra.Command{
 		Use:     "app",
-		Version: "2.22",
+		Version: "2.23",


Why do we need to update the version in 3 places? Can't we inject it at build time via linker?

I agree that it is not ok to have such kind of duplication, but I do not implement it here. I just do minimal changes needed to fix the issue.

sure, that's fine - I don't know who owns this sub-component now, so I guess I hope they see this and agree.

johngmyers · 2020-09-10T16:37:59Z

I've always wondered why the cluster domain isn't available through the downward API.

vponomaryov · 2020-09-10T20:21:25Z

/unassign @mkumatag
/unassign @listx
/unassign @luxas

vponomaryov · 2020-09-22T10:27:02Z

@thockin are the added description comments look good for you?
@claudiubelu can you please revisit this PR?

fejta

/approve
the build changes

k8s-ci-robot · 2020-09-22T21:47:12Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: claudiubelu, fejta, vponomaryov

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~build/OWNERS~~ [fejta]
~~test/images/agnhost/OWNERS~~ [claudiubelu,fejta]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

'agnhost' image uses hardcoded 'cluster.local' value for DNS domain. It leads to failure of a bunch of HPA tests when test cluster is configured to use custom DNS domain and there is no alias for default 'cluster.local' one. So, fix it by reusing it's own function for reading DNS domain suffixes. Signed-off-by: Valerii Ponomarov <kiparis.kh@gmail.com>

claudiubelu · 2020-09-24T11:30:16Z

/lgtm

k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/bug Categorizes issue or PR as related to a bug. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jul 10, 2020

k8s-ci-robot added area/test sig/testing Categorizes an issue or PR as relevant to SIG Testing. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Jul 10, 2020

k8s-ci-robot requested review from listx and mkumatag July 10, 2020 11:42

vponomaryov force-pushed the issue-88752-in-master branch from 4ab7aea to 93089de Compare July 10, 2020 14:51

k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Jul 10, 2020

k8s-ci-robot added the sig/autoscaling Categorizes an issue or PR as relevant to SIG Autoscaling. label Jul 10, 2020

k8s-ci-robot assigned claudiubelu and luxas Jul 10, 2020

k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jul 15, 2020

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 3, 2020

k8s-ci-robot assigned fejta Sep 7, 2020

k8s-ci-robot added this to the v1.20 milestone Sep 8, 2020

k8s-ci-robot added the sig/network Categorizes an issue or PR as relevant to SIG Network. label Sep 9, 2020

k8s-ci-robot assigned thockin Sep 9, 2020

thockin reviewed Sep 9, 2020

View reviewed changes

vponomaryov force-pushed the issue-88752-in-master branch from da7d8b7 to 754331b Compare September 10, 2020 12:03

k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 10, 2020

fejta reviewed Sep 22, 2020

View reviewed changes

k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 22, 2020

vponomaryov force-pushed the issue-88752-in-master branch from 754331b to c55b6cd Compare September 24, 2020 11:25

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 24, 2020

k8s-ci-robot merged commit b58777e into kubernetes:master Sep 24, 2020

vponomaryov mentioned this pull request Sep 24, 2020

Resource consumer controller does not respect configured dns domain #88752

Closed

aojea mentioned this pull request Oct 30, 2020

new NetworkPolicy Validation suite #91592

Merged

agnhost image: use actual DNS domain instead of hardcoded cluster.local #92964

agnhost image: use actual DNS domain instead of hardcoded cluster.local #92964

Conversation

vponomaryov commented Jul 10, 2020 • edited

k8s-ci-robot commented Jul 10, 2020

k8s-ci-robot commented Jul 10, 2020

k8s-ci-robot commented Jul 10, 2020

vponomaryov commented Jul 10, 2020

vponomaryov commented Jul 10, 2020

k8s-ci-robot commented Jul 10, 2020

vponomaryov commented Jul 10, 2020

gjtempleton commented Jul 10, 2020

vponomaryov commented Jul 10, 2020

listx commented Jul 15, 2020

claudiubelu commented Sep 3, 2020

jtslear commented Sep 4, 2020

k8s-ci-robot commented Sep 4, 2020

vponomaryov commented Sep 7, 2020

justaugustus commented Sep 8, 2020

vponomaryov commented Sep 8, 2020

claudiubelu commented Sep 9, 2020

liggitt commented Sep 9, 2020

liggitt commented Sep 9, 2020 • edited

thockin left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

johngmyers commented Sep 10, 2020

vponomaryov commented Sep 10, 2020 • edited

vponomaryov commented Sep 22, 2020 • edited

fejta left a comment

Choose a reason for hiding this comment

k8s-ci-robot commented Sep 22, 2020

claudiubelu commented Sep 24, 2020

vponomaryov commented Jul 10, 2020 •

edited

liggitt commented Sep 9, 2020 •

edited

vponomaryov commented Sep 10, 2020 •

edited

vponomaryov commented Sep 22, 2020 •

edited