Update to version 2.5.1 of the fluent-plugin-kubernetes_metadata_filter #92974

Ghazgkull · 2020-07-10T20:43:22Z

What type of PR is this?

/kind bug

What this PR does / why we need it:

Updates to version 2.5.1 of the fluent-plugin-kubernetes_metadata_filter plugin. This version of the plugin contains a change to address the problem of unhandled "410 Gone" errors during the plugin's pod watch. (See fabric8io/fluent-plugin-kubernetes_metadata_filter#243)

Which issue(s) this PR fixes:

Fixes fabric8io/fluent-plugin-kubernetes_metadata_filter#226

Special notes for your reviewer:

@monotek I originally reported this defect to the fluentd-elasticsearch helm chart a couple months back and you thankfully rolled back to an earlier version in order to avoid this bug: kiwigrid/helm-charts#340 (comment)

I jumped in and contributed a fix to the kubernetes metadata filter plugin which is now available in this release.

Does this PR introduce a user-facing change?:

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

k8s-ci-robot · 2020-07-10T20:43:26Z

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.

If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
If you signed the CLA as a corporation, please sign in with your organization's credentials at https://identity.linuxfoundation.org/projects/cncf to be authorized.
If you have done the above and are still having issues with the CLA being reported as unsigned, please log a ticket with the Linux Foundation Helpdesk: https://support.linuxfoundation.org/
Should you encounter any issues with the Linux Foundation Helpdesk, send a message to the backup e-mail support address at: login-issues@jira.linuxfoundation.org

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

k8s-ci-robot · 2020-07-10T20:43:30Z

Welcome @Ghazgkull!

It looks like this is your first PR to kubernetes/kubernetes 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/kubernetes has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

k8s-ci-robot · 2020-07-10T20:43:31Z

Hi @Ghazgkull. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Ghazgkull · 2020-07-10T20:53:38Z

I signed it

monotek

/lgtm
/approve
/ok-to-test

monotek

Sorry, I've just recognized you did not raised the image version in the makefile.

Ghazgkull · 2020-07-11T15:12:35Z

@monotek Thanks for the heads up. Image version bumped now.

monotek · 2020-07-12T13:20:23Z

/unhold

Ghazgkull · 2020-07-12T14:40:39Z

Thanks, @monotek. This is my first contribution to this project so I’m not 100% sure of the PR process here. Is there someone I should reach out to now to request this change be merged?

Ghazgkull · 2020-07-12T15:39:49Z

The bots are saying this PR needs to be targetted to milestone v1.19. I'm assuming I don't have permission to do that myself?

/milestone v1.19

k8s-ci-robot · 2020-07-12T15:39:51Z

@Ghazgkull: You must be a member of the kubernetes/milestone-maintainers GitHub team to set the milestone. If you believe you should be able to issue the /milestone command, please contact your and have them propose you as an additional delegate for this responsibility.

In response to this:

The bots are saying this PR needs to be targetted to milestone v1.19. I'm assuming I don't have permission to do that myself?

/milestone v1.19

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Ghazgkull · 2020-07-12T17:38:41Z

/kind bug

Ghazgkull · 2020-07-12T18:14:26Z

@DirectXMan12 @kawych Can I please request help applying the required milestone tag?

Ghazgkull · 2020-07-13T17:57:21Z

Apologies for all the chatter. I'm new to the project here and trying to navigate the process for the first time. As an outsider, I don't have permission to actually view project membership (https://github.com/orgs/kubernetes/teams/milestone-maintainers/members gives me a 404), so I'm left groping in the dark.

@coffeepac Looking through other PRs in this area, I see your approvals appearing before the bot adds the v1.19 milestone label. So I'm speculating that you might be the approval I need?

Ghazgkull · 2020-07-13T21:52:29Z

More noise... I realize now that the problem is that /lgtm was removed by the bot when I added the Makefile change it didn't get restored when @monotek re-approved the change.

nikhita · 2020-07-14T06:17:06Z

@monotek can you re-apply lgtm?

/assign @onlydole
(release team lead) for applying the milestone

monotek

/lgtm
/approve

k8s-ci-robot · 2020-07-14T11:51:24Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Ghazgkull, monotek

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~cluster/addons/fluentd-elasticsearch/OWNERS~~ [monotek]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

justaugustus · 2020-07-15T19:16:14Z

/milestone v1.19

Ghazgkull · 2020-07-15T21:22:04Z

/retest

Ghazgkull · 2020-07-15T21:45:38Z

/retest

Ghazgkull · 2020-07-16T00:22:38Z

/retest

nikhita · 2020-07-16T03:11:27Z

/retest

justaugustus · 2020-07-16T06:01:51Z

/retest

monotek · 2020-07-16T12:44:13Z

I've just pushed the image to quay.io/fluentd_elasticsearch/fluentd:v3.0.3 :)

Update to version 2.5.1 of the fluent-plugin-kubernetes_metadata_filter

29cdaad

k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Jul 10, 2020

k8s-ci-robot added cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. labels Jul 10, 2020

k8s-ci-robot added needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jul 10, 2020

k8s-ci-robot requested review from DirectXMan12 and kawych July 10, 2020 20:43

k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Jul 10, 2020

monotek approved these changes Jul 11, 2020

View reviewed changes

k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jul 11, 2020

k8s-ci-robot assigned monotek Jul 11, 2020

k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jul 11, 2020

monotek suggested changes Jul 11, 2020

View reviewed changes

k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 11, 2020

Bump image version

15bf1b1

k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 11, 2020

monotek approved these changes Jul 12, 2020

View reviewed changes

k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 12, 2020

k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. and removed needs-kind Indicates a PR lacks a `kind/foo` label and requires one. labels Jul 12, 2020

k8s-ci-robot assigned onlydole Jul 14, 2020

monotek approved these changes Jul 14, 2020

View reviewed changes

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 14, 2020

Ghazgkull mentioned this pull request Jul 15, 2020

Update fluent-plugin-elasticsearch (4.1.0) and fluent-plugin-kubernetes_metadata_filter (2.5.2) #93116

Merged

k8s-ci-robot added this to the v1.19 milestone Jul 15, 2020

k8s-ci-robot merged commit 03509f3 into kubernetes:master Jul 16, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update to version 2.5.1 of the fluent-plugin-kubernetes_metadata_filter #92974

Update to version 2.5.1 of the fluent-plugin-kubernetes_metadata_filter #92974

Ghazgkull commented Jul 10, 2020 •

edited

k8s-ci-robot commented Jul 10, 2020

k8s-ci-robot commented Jul 10, 2020

k8s-ci-robot commented Jul 10, 2020

Ghazgkull commented Jul 10, 2020

monotek left a comment

monotek left a comment •

edited

Ghazgkull commented Jul 11, 2020 •

edited

monotek commented Jul 12, 2020

Ghazgkull commented Jul 12, 2020

Ghazgkull commented Jul 12, 2020

k8s-ci-robot commented Jul 12, 2020

Ghazgkull commented Jul 12, 2020 •

edited

Ghazgkull commented Jul 12, 2020

Ghazgkull commented Jul 13, 2020

Ghazgkull commented Jul 13, 2020

nikhita commented Jul 14, 2020

monotek left a comment

k8s-ci-robot commented Jul 14, 2020

justaugustus commented Jul 15, 2020

Ghazgkull commented Jul 15, 2020

Ghazgkull commented Jul 15, 2020

Ghazgkull commented Jul 16, 2020

nikhita commented Jul 16, 2020

justaugustus commented Jul 16, 2020

monotek commented Jul 16, 2020

Update to version 2.5.1 of the fluent-plugin-kubernetes_metadata_filter #92974

Update to version 2.5.1 of the fluent-plugin-kubernetes_metadata_filter #92974

Conversation

Ghazgkull commented Jul 10, 2020 • edited

k8s-ci-robot commented Jul 10, 2020

k8s-ci-robot commented Jul 10, 2020

k8s-ci-robot commented Jul 10, 2020

Ghazgkull commented Jul 10, 2020

monotek left a comment

Choose a reason for hiding this comment

monotek left a comment • edited

Choose a reason for hiding this comment

Ghazgkull commented Jul 11, 2020 • edited

monotek commented Jul 12, 2020

Ghazgkull commented Jul 12, 2020

Ghazgkull commented Jul 12, 2020

k8s-ci-robot commented Jul 12, 2020

Ghazgkull commented Jul 12, 2020 • edited

Ghazgkull commented Jul 12, 2020

Ghazgkull commented Jul 13, 2020

Ghazgkull commented Jul 13, 2020

nikhita commented Jul 14, 2020

monotek left a comment

Choose a reason for hiding this comment

k8s-ci-robot commented Jul 14, 2020

justaugustus commented Jul 15, 2020

Ghazgkull commented Jul 15, 2020

Ghazgkull commented Jul 15, 2020

Ghazgkull commented Jul 16, 2020

nikhita commented Jul 16, 2020

justaugustus commented Jul 16, 2020

monotek commented Jul 16, 2020

Ghazgkull commented Jul 10, 2020 •

edited

monotek left a comment •

edited

Ghazgkull commented Jul 11, 2020 •

edited

Ghazgkull commented Jul 12, 2020 •

edited