Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update yaml files to use seccomp GA syntax #93095

Merged
merged 1 commit into from Aug 28, 2020
Merged

Update yaml files to use seccomp GA syntax #93095

merged 1 commit into from Aug 28, 2020

Conversation

pjbgf
Copy link
Member

@pjbgf pjbgf commented Jul 15, 2020

What type of PR is this?
/kind cleanup

What this PR does / why we need it:
Seccomp became GA on v1.19 and its usage now uses fields instead of annotations. This PR migrates all yaml files inside this repository to the GA syntax.

Which issue(s) this PR fixes:

Relates to #91286

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

/sig node
/area security

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note-none Denotes a PR that doesn't merit a release note. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. sig/node Categorizes an issue or PR as relevant to SIG Node. area/security cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. area/provider/gcp Issues or PRs related to gcp provider sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. labels Jul 15, 2020
@k8s-ci-robot k8s-ci-robot added sig/instrumentation Categorizes an issue or PR as relevant to SIG Instrumentation. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Jul 15, 2020
@pjbgf
Copy link
Member Author

pjbgf commented Jul 16, 2020

/retest

@liggitt
Copy link
Member

liggitt commented Jul 18, 2020

https://prow.k8s.io/view/gcs/kubernetes-jenkins/pr-logs/pull/93095/pull-kubernetes-node-e2e/1283657114006327296 flake is #93210

@pjbgf pjbgf changed the title WIP - update yaml files to use seccomp GA syntax Update yaml files to use seccomp GA syntax Aug 1, 2020
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 1, 2020
@pjbgf
Copy link
Member Author

pjbgf commented Aug 1, 2020

/assign @bryk @dashpole @MrHohn

@pjbgf
Copy link
Member Author

pjbgf commented Aug 1, 2020

/retest

@liggitt
Copy link
Member

liggitt commented Aug 1, 2020

one comment, looks good otherwise. did you try creating these to make sure syntax was correct?

@dashpole
Copy link
Contributor

dashpole commented Aug 5, 2020

/approve

1 similar comment
@MrHohn
Copy link
Member

MrHohn commented Aug 11, 2020

/approve

@spiffxp
Copy link
Member

spiffxp commented Aug 13, 2020

/retest
Is this something we want to land for v1.19?

@pjbgf
Copy link
Member Author

pjbgf commented Aug 13, 2020

one comment, looks good otherwise. did you try creating these to make sure syntax was correct?

Yes, I tested the yaml files and got no syntax errors.

@pjbgf
Copy link
Member Author

pjbgf commented Aug 13, 2020

/retest
Is this something we want to land for v1.19?

This would be a nice to have.

@pjbgf
Copy link
Member Author

pjbgf commented Aug 13, 2020

/retest

@pjbgf
Copy link
Member Author

pjbgf commented Aug 13, 2020

/test pull-kubernetes-e2e-kind-ipv6

@pjbgf pjbgf requested a review from liggitt August 13, 2020 16:14
@liggitt
Copy link
Member

liggitt commented Aug 13, 2020

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 13, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dashpole, liggitt, MrHohn, pjbgf

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 13, 2020
@justaugustus justaugustus added this to the v1.20 milestone Aug 27, 2020
@liggitt
Copy link
Member

liggitt commented Aug 28, 2020

/retest

@liggitt
Copy link
Member

liggitt commented Aug 28, 2020

/skip

@liggitt
Copy link
Member

liggitt commented Aug 28, 2020

looks like https://prow.k8s.io/job-history/gs/kubernetes-jenkins/pr-logs/directory/pull-kubernetes-e2e-gce-network-proxy-grpc is solidly failing

/skip

@liggitt liggitt mentioned this pull request Aug 28, 2020
Merged
@liggitt
Copy link
Member

liggitt commented Aug 28, 2020

opened kubernetes/test-infra#19033 to make the failing job optional

@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@spiffxp
Copy link
Member

spiffxp commented Aug 28, 2020

/override pull-kubernetes-e2e-gce-network-proxy-grpc

@k8s-ci-robot
Copy link
Contributor

@spiffxp: Overrode contexts on behalf of spiffxp: pull-kubernetes-e2e-gce-network-proxy-grpc

In response to this:

/override pull-kubernetes-e2e-gce-network-proxy-grpc

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@pjbgf
Copy link
Member Author

pjbgf commented Aug 28, 2020

/test pull-kubernetes-e2e-gce-ubuntu-containerd

@k8s-ci-robot k8s-ci-robot merged commit b440ecc into kubernetes:master Aug 28, 2020
@vinayakankugoyal vinayakankugoyal mentioned this pull request Mar 15, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spiffxp spiffxp spiffxp left review comments

@freehan freehan Awaiting requested review from freehan

@tallclair tallclair Awaiting requested review from tallclair

@liggitt liggitt Awaiting requested review from liggitt

Assignees

@liggitt liggitt

@bryk bryk

@dashpole dashpole

@MrHohn MrHohn

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/provider/gcp Issues or PRs related to gcp provider area/security cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. release-note-none Denotes a PR that doesn't merit a release note. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. sig/instrumentation Categorizes an issue or PR as relevant to SIG Instrumentation. sig/node Categorizes an issue or PR as relevant to SIG Node. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
v1.20
Development

Successfully merging this pull request may close these issues.

None yet
9 participants
@pjbgf @liggitt @dashpole @MrHohn @spiffxp @k8s-ci-robot @fejta-bot @justaugustus @bryk