Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Golang to v1.14.6 #93198

Merged
merged 2 commits into from Jul 19, 2020
Merged

Update Golang to v1.14.6 #93198

merged 2 commits into from Jul 19, 2020

Conversation

justaugustus
Copy link
Member

What type of PR is this?
/kind cleanup
/area dependency release-eng
/sig release

What this PR does / why we need it:

Update Golang to v1.14.6

Signed-off-by: Stephen Augustus saugustus@vmware.com

/assign @liggitt @cblecker @dims @BenTheElder @listx
cc: @kubernetes/release-engineering @mkumatag
Tracking issue: kubernetes/release#1410

Does this PR introduce a user-facing change?:

- Update Golang to v1.14.6
- Update repo-infra to 0.0.8 (to support go1.14.6 and go1.13.14)
  - Includes:
    - bazelbuild/bazel-toolchains@3.4.0
    - bazelbuild/rules_go@v0.22.8

@justaugustus
Update repo-infra to v0.0.8 (to support go1.14.6 and go1.13.14)
bddd520 
Includes:
- bazelbuild/bazel-toolchains@3.4.0
- bazelbuild/rules_go@v0.22.8

Signed-off-by: Stephen Augustus <saugustus@vmware.com>
@justaugustus
Update Golang to v1.14.6
3bbcba9 
Signed-off-by: Stephen Augustus <saugustus@vmware.com>
@k8s-ci-robot k8s-ci-robot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Jul 17, 2020
@k8s-ci-robot k8s-ci-robot added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label Jul 17, 2020
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. area/dependency Issues or PRs related to dependency changes area/release-eng Issues or PRs related to the Release Engineering subproject sig/release Categorizes an issue or PR as relevant to SIG Release. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. area/test labels Jul 17, 2020
@k8s-ci-robot k8s-ci-robot added the sig/testing Categorizes an issue or PR as relevant to SIG Testing. label Jul 17, 2020
@liggitt
Copy link
Member

liggitt commented Jul 17, 2020

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 17, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: justaugustus, liggitt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 17, 2020
@mkumatag mkumatag mentioned this pull request Jul 17, 2020
Closed
18 tasks
@justaugustus
Copy link
Member Author

/milestone v1.19

@k8s-ci-robot k8s-ci-robot added this to the v1.19 milestone Jul 17, 2020
@justaugustus
Copy link
Member Author

/test pull-kubernetes-conformance-kind-ga-only-parallel

@justaugustus
Copy link
Member Author

/test pull-kubernetes-integration
/test pull-kubernetes-e2e-gce-device-plugin-gpu
/test pull-kubernetes-node-e2e

@justaugustus
Copy link
Member Author

/test pull-kubernetes-e2e-gce

@justaugustus justaugustus mentioned this pull request Jul 17, 2020
Merged
@justaugustus
Copy link
Member Author

/test pull-kubernetes-e2e-gce-100-performance

@justaugustus
Copy link
Member Author

/test pull-kubernetes-e2e-gce
/test pull-kubernetes-e2e-gce-device-plugin-gpu

@justaugustus
Copy link
Member Author

/test pull-kubernetes-e2e-gce-device-plugin-gpu

1 similar comment
@justaugustus
Copy link
Member Author

/test pull-kubernetes-e2e-gce-device-plugin-gpu

@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

1 similar comment
@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@feiskyer
Copy link
Member

/retest

4 similar comments
@justaugustus
Copy link
Member Author

/retest

@justaugustus
Copy link
Member Author

/retest

@justaugustus
Copy link
Member Author

/retest

@justaugustus
Copy link
Member Author

/retest

@justaugustus
Copy link
Member Author

/test pull-kubernetes-e2e-gce

@justaugustus
Copy link
Member Author

/test pull-kubernetes-e2e-gce-device-plugin-gpu

@hasheddan
Copy link
Contributor

hasheddan commented Jul 18, 2020 •
edited

@justaugustus just a heads up pull-kubernetes-e2e-gce-device-plugin-gpu is having issues right now (#93187). Proposed fix open here: #93207

@justaugustus
Copy link
Member Author

Thanks for the heads-up, Dan!

/test pull-kubernetes-kubemark-e2e-gce-big

@justaugustus
Copy link
Member Author

/retest

1 similar comment
@justaugustus
Copy link
Member Author

/retest

@justaugustus
Copy link
Member Author

/test pull-kubernetes-e2e-gce

@justaugustus
Copy link
Member Author

/retest

1 similar comment
@justaugustus
Copy link
Member Author

/retest

@liggitt
Copy link
Member

liggitt commented Jul 19, 2020

https://prow.k8s.io/view/gs/kubernetes-jenkins/pr-logs/pull/93198/pull-kubernetes-e2e-gce/1284552801854164994 flake is #93215, fix in #93216

@liggitt
Copy link
Member

liggitt commented Jul 19, 2020

/skip

@justaugustus
Copy link
Member Author

/test pull-kubernetes-e2e-gce-100-performance

@mkumatag
Copy link
Member

/retest

@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Jul 19, 2020 •
edited

@justaugustus: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
pull-kubernetes-e2e-gce-device-plugin-gpu 3bbcba9 link /test pull-kubernetes-e2e-gce-device-plugin-gpu

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@justaugustus
Copy link
Member Author

/retest

@k8s-ci-robot k8s-ci-robot merged commit 363c3b8 into kubernetes:master Jul 19, 2020
@nikhita nikhita mentioned this pull request Jul 20, 2020
Merged
@github-actions github-actions bot mentioned this pull request Jul 22, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BenTheElder BenTheElder Awaiting requested review from BenTheElder

@spiffxp spiffxp Awaiting requested review from spiffxp

Assignees

@dims dims

@listx listx

@BenTheElder BenTheElder

@liggitt liggitt

@cblecker cblecker

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/dependency Issues or PRs related to dependency changes area/release-eng Issues or PRs related to the Release Engineering subproject area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/release Categorizes an issue or PR as relevant to SIG Release. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
v1.19
Development

Successfully merging this pull request may close these issues.

None yet