Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle int -> float conversion in FromUnstructured #93250

Merged
merged 1 commit into from Aug 30, 2020
Merged

Handle int -> float conversion in FromUnstructured #93250

merged 1 commit into from Aug 30, 2020

Conversation

liggitt
Copy link
Member

@liggitt liggitt commented Jul 20, 2020

What type of PR is this?
/kind bug

What this PR does / why we need it:
Handles int -> float conversions in FromUnstructured

Which issue(s) this PR fixes:
Fixes #87675

Does this PR introduce a user-facing change?:

k8s.io/apimachinery: runtime.DefaultUnstructuredConverter.FromUnstructured now handles converting integer fields to typed float values

/cc @sttts
/sig api-machinery

@k8s-ci-robot k8s-ci-robot requested a review from sttts July 20, 2020 14:43
@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/bug Categorizes issue or PR as related to a bug. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. and removed needs-kind Indicates a PR lacks a `kind/foo` label and requires one. labels Jul 20, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: liggitt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@liggitt liggitt mentioned this pull request Jul 20, 2020
Closed
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 20, 2020
@liggitt liggitt added the priority/backlog Higher priority than priority/awaiting-more-evidence. label Jul 20, 2020
@k8s-ci-robot k8s-ci-robot removed the needs-priority Indicates a PR lacks a `priority/foo` label and requires one. label Jul 20, 2020
@dims
Copy link
Member

dims commented Jul 21, 2020

/retest
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 21, 2020
@fedebongio
Copy link
Contributor

/assign @roycaihw

@roycaihw
Copy link
Member

/lgtm

@liggitt liggitt added this to the v1.20 milestone Jul 24, 2020
@dims dims removed their assignment Jul 26, 2020
@liggitt liggitt removed this from the v1.20 milestone Aug 26, 2020
hasheddan
hasheddan approved these changes Aug 28, 2020
View reviewed changes
Copy link
Contributor

@hasheddan hasheddan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@liggitt will this fall into phase 5 of 1.20 reopening?

@liggitt liggitt added this to the v1.20-phase-bug-low-risk milestone Aug 28, 2020
@justaugustus
Copy link
Member

/test pull-kubernetes-e2e-kind-ipv6

@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@k8s-ci-robot k8s-ci-robot merged commit 6a11d1f into kubernetes:master Aug 30, 2020
@liggitt liggitt deleted the unstructured-int-float branch August 31, 2020 01:22
@hasheddan hasheddan mentioned this pull request Sep 10, 2020
Merged
4 tasks
@kscharm kscharm mentioned this pull request Feb 23, 2021
Closed
@liggitt liggitt mentioned this pull request Jun 23, 2021
Merged
k8s-ci-robot added a commit that referenced this pull request Jun 24, 2021
@k8s-ci-robot
Merge pull request #103105 from liggitt/automated-cherry-pick-of-#932…
3c4329c 
…50-upstream-release-1.19

Automated cherry pick of #93250: Handle int -> float conversion in FromUnstructured
@jetmuffin jetmuffin mentioned this pull request Jul 6, 2021
Closed
@innobead innobead mentioned this pull request Apr 1, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hasheddan hasheddan hasheddan approved these changes

@sttts sttts Awaiting requested review from sttts

Assignees

@roycaihw roycaihw

@hasheddan hasheddan

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/backlog Higher priority than priority/awaiting-more-evidence. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
v1.20
8 participants
@liggitt @k8s-ci-robot @dims @fedebongio @roycaihw @justaugustus @fejta-bot @hasheddan