Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename pod_preemption_metrics to preemption_metrics. #93256

Merged
merged 1 commit into from Jul 21, 2020
Merged

Rename pod_preemption_metrics to preemption_metrics. #93256

merged 1 commit into from Jul 21, 2020

Conversation

ahg-g
Copy link
Member

@ahg-g ahg-g commented Jul 20, 2020 •
edited

What type of PR is this?

/kind feature

What this PR does / why we need it:

Since this metric's type was changed from Gauge to Histogram, renaming it should make it easier for providers to migrate. Also, the name now matches better with preemption_attempts_total (_total suffix because it is a counter)

Which issue(s) this PR fixes:
Part off #83464

Does this PR introduce a user-facing change?:

Rename pod_preemption_metrics to preemption_metrics.

@ahg-g
Rename pod_preemption_metrics to preemption_metrics. Since this metri…
6f9794d 
…c's type was changed from Gauge to Histogram, renaming it should make it easier to providers to migrate
@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/feature Categorizes issue or PR as related to a new feature. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Jul 20, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahg-g

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. sig/instrumentation Categorizes an issue or PR as relevant to SIG Instrumentation. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Jul 20, 2020
@ahg-g
Copy link
Member Author

ahg-g commented Jul 20, 2020

/retest

@ahg-g
Copy link
Member Author

ahg-g commented Jul 20, 2020

/assign @logicalhan

@logicalhan
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 20, 2020
@ahg-g
Copy link
Member Author

ahg-g commented Jul 20, 2020

/retest

@ahg-g
Copy link
Member Author

ahg-g commented Jul 20, 2020

@Huang-Wei let me know if you have concerns.

@ahg-g
Copy link
Member Author

ahg-g commented Jul 20, 2020

/milestone v1.19

@k8s-ci-robot k8s-ci-robot added this to the v1.19 milestone Jul 20, 2020
@ahg-g
Copy link
Member Author

ahg-g commented Jul 20, 2020

/priority important-soon

@k8s-ci-robot k8s-ci-robot added priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. and removed needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Jul 20, 2020
@Huang-Wei
Copy link
Member

@Huang-Wei let me know if you have concerns.

LGTM.

@k8s-ci-robot k8s-ci-robot merged commit b467072 into kubernetes:master Jul 21, 2020
@liggitt
Copy link
Member

liggitt commented Jul 21, 2020

https://prow.k8s.io/view/gcs/kubernetes-jenkins/pr-logs/pull/93256/pull-kubernetes-node-e2e/1285239828731924480 flake was #93210

@github-actions github-actions bot mentioned this pull request Jul 27, 2020
Open
@ahg-g ahg-g deleted the ahg-metric branch October 25, 2021 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@k82cn k82cn Awaiting requested review from k82cn

@liu-cong liu-cong Awaiting requested review from liu-cong

Assignees

@logicalhan logicalhan

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/instrumentation Categorizes an issue or PR as relevant to SIG Instrumentation. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v1.19
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@ahg-g @k8s-ci-robot @logicalhan @Huang-Wei @liggitt