Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow integration test servers extra time to start #93398

Merged
merged 1 commit into from Jul 24, 2020
Merged

Allow integration test servers extra time to start #93398

merged 1 commit into from Jul 24, 2020

Conversation

liggitt
Copy link
Member

@liggitt liggitt commented Jul 23, 2020

What type of PR is this?
/kind flake

What this PR does / why we need it:

In CI environments without reserved resources for the test pod, the CPU dedicated to an individual integration test can be much lower than expected. The test apiserver has much more to do during startup before /healthz will return healthy (all post-startup hooks have to complete), and occasionally this does not complete within 30 seconds.

See https://storage.googleapis.com/k8s-gubernator/triage/index.html?pr=1&text=%2Fhealthz&job=pull-kubernetes-integration

Avoid failing tests due to unrelated CPU starvation.

Does this PR introduce a user-facing change?:

NONE

/sig api-machinery
/cc @deads2k

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/flake Categorizes issue or PR as related to a flaky test. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. area/apiserver and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Jul 23, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: liggitt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added triage/needs-information Indicates an issue needs more information in order to work on it. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jul 23, 2020
hasheddan
hasheddan approved these changes Jul 23, 2020
View reviewed changes
Copy link
Contributor

@hasheddan hasheddan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/retest

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 23, 2020
@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@liggitt liggitt added this to the v1.19 milestone Jul 24, 2020
@liggitt
Copy link
Member Author

liggitt commented Jul 24, 2020

including in the milestone to improve CI signal

@liggitt
Copy link
Member Author

liggitt commented Jul 24, 2020

/retest

@liggitt liggitt added the priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. label Jul 24, 2020
@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@nikhita
Copy link
Member

nikhita commented Jul 24, 2020

/retest

2 similar comments
@hasheddan
Copy link
Contributor

/retest

@nikhita
Copy link
Member

nikhita commented Jul 24, 2020

/retest

@k8s-ci-robot k8s-ci-robot merged commit b826d39 into kubernetes:master Jul 24, 2020
@liggitt liggitt deleted the apiserver-integration-startup branch July 27, 2020 13:55
@fedebongio
Copy link
Contributor

/remove-triage needs-information

@k8s-ci-robot k8s-ci-robot removed the triage/needs-information Indicates an issue needs more information in order to work on it. label Jul 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hasheddan hasheddan hasheddan approved these changes

@deads2k deads2k Awaiting requested review from deads2k

Assignees

@hasheddan hasheddan

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/apiserver cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/flake Categorizes issue or PR as related to a flaky test. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. release-note-none Denotes a PR that doesn't merit a release note. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v1.19
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@liggitt @k8s-ci-robot @fejta-bot @nikhita @hasheddan @fedebongio