Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mark default ingressclass tests serial, do not set default ingressclass in conformance #93427

Merged
merged 1 commit into from Jul 24, 2020
Merged

Mark default ingressclass tests serial, do not set default ingressclass in conformance #93427

merged 1 commit into from Jul 24, 2020

Conversation

liggitt
Copy link
Member

@liggitt liggitt commented Jul 24, 2020

What type of PR is this?
/kind bug
/kind flake

What this PR does / why we need it:

  1. Marks e2e tests that deal with default ingressclasses as serial
  2. Avoids creating default ingressclasses in conformance e2e API tests

Which issue(s) this PR fixes:
Fixes #93424

Does this PR introduce a user-facing change?:

NONE

/cc @robscott @cmluciano
/sig network
/milestone v1.19

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/bug Categorizes issue or PR as related to a bug. kind/flake Categorizes issue or PR as related to a flaky test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. sig/network Categorizes an issue or PR as relevant to SIG Network. labels Jul 24, 2020
@k8s-ci-robot k8s-ci-robot added this to the v1.19 milestone Jul 24, 2020
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Jul 24, 2020
@liggitt liggitt mentioned this pull request Jul 24, 2020
Closed
@k8s-ci-robot k8s-ci-robot added area/test sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Jul 24, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: liggitt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 24, 2020
@liggitt
Copy link
Member Author

liggitt commented Jul 24, 2020

/retest

cmluciano
cmluciano reviewed Jul 24, 2020
View reviewed changes
Copy link

@cmluciano cmluciano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You beat me to it :)

Thanks!

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 24, 2020
@liggitt
Copy link
Member Author

liggitt commented Jul 24, 2020

CSI mock volume flake

/retest

@liggitt
Copy link
Member Author

liggitt commented Jul 24, 2020

timeout with no individual test failures

/retest

@liggitt
Copy link
Member Author

liggitt commented Jul 24, 2020

bazel flake: build aborted: no such package '@debian-iptables-amd64//image

/retest

@liggitt liggitt added the priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. label Jul 24, 2020
@k8s-ci-robot k8s-ci-robot removed the needs-priority Indicates a PR lacks a `priority/foo` label and requires one. label Jul 24, 2020
@liggitt
Copy link
Member Author

liggitt commented Jul 24, 2020

pod pending timeout

/retest

@k8s-ci-robot k8s-ci-robot merged commit c0a4d4b into kubernetes:master Jul 24, 2020
@liggitt liggitt deleted the default-ingress-class branch July 27, 2020 13:55
@cmluciano cmluciano mentioned this pull request Sep 14, 2020
Closed
6 tasks
@kolyshkin kolyshkin mentioned this pull request Oct 12, 2020
Merged
kolyshkin added a commit to kolyshkin/cri-o that referenced this pull request Nov 19, 2020
@kolyshkin
contrib/test/int/e2e-features: skip Serial tests
22ce1d7 
This is mostly done to fix the flake caused by the test case

> Kubernetes e2e suite: [sig-network] IngressClass [Feature:Ingress] should not set default value if no default IngressClass [Serial]

which fails like this:

> ingressclasses.networking.k8s.io "ingressclass1" already exists

This test depends on a system state and thus can't be run in parallel.
It was marked as [Serial] recently (see [1]) but I just found out
we do not skip Serial tests in e2e-features.

Fix this.

[1] kubernetes/kubernetes#93427

Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
@kolyshkin kolyshkin mentioned this pull request Nov 19, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cmluciano cmluciano cmluciano left review comments

@robscott robscott Awaiting requested review from robscott

Assignees

@cmluciano cmluciano

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. kind/flake Categorizes issue or PR as related to a flaky test. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. release-note-none Denotes a PR that doesn't merit a release note. sig/network Categorizes an issue or PR as relevant to SIG Network. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
v1.19
Development

Successfully merging this pull request may close these issues.

[Flaky test] [sig-network] Ingress API should support creating Ingress API operations [Conformance]
3 participants
@liggitt @k8s-ci-robot @cmluciano