Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Automated cherry pick of #93207: Use local daemonset manifest for installing Nvidia drivers #93453

Merged
merged 1 commit into from Jul 28, 2020
Merged

Automated cherry pick of #93207: Use local daemonset manifest for installing Nvidia drivers #93453

merged 1 commit into from Jul 28, 2020

Conversation

hasheddan
Copy link
Contributor

Cherry pick of #93207 on release-1.17.

#93207: Use local daemonset manifest for installing Nvidia drivers

For details on the cherry pick process, see the cherry pick requests page.

@k8s-ci-robot k8s-ci-robot added this to the v1.17 milestone Jul 26, 2020
@k8s-ci-robot k8s-ci-robot added do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Jul 26, 2020
@k8s-ci-robot k8s-ci-robot added sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. sig/testing Categorizes an issue or PR as relevant to SIG Testing. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Jul 26, 2020
@hasheddan
Copy link
Contributor Author

/release-note-none

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Jul 26, 2020
@hasheddan hasheddan force-pushed the automated-cherry-pick-of-#93207-upstream-release-1.17 branch 2 times, most recently from 21f5d4e to e611ce7 Compare July 26, 2020 17:41
@hasheddan
Copy link
Contributor Author

/assign @ahg-g @Huang-Wei

This one is still failing on 1.17-blocking due to the issue with using latest installer image https://testgrid.k8s.io/sig-release-1.17-blocking#gce-device-plugin-gpu-1.17

@hasheddan hasheddan force-pushed the automated-cherry-pick-of-#93207-upstream-release-1.17 branch from e611ce7 to c6030fe Compare July 26, 2020 18:01
@k8s-ci-robot k8s-ci-robot added the area/e2e-test-framework Issues or PRs related to refactoring the kubernetes e2e test framework label Jul 26, 2020
@hasheddan
Copy link
Contributor Author

/test pull-kubernetes-kubemark-e2e-gce-big

@hasheddan
Copy link
Contributor Author

/retest

1 similar comment
@hasheddan
Copy link
Contributor Author

/retest

@hasheddan
Copy link
Contributor Author

@kubernetes/release-managers

justaugustus
justaugustus requested changes Jul 26, 2020
View reviewed changes
Copy link
Member

@justaugustus justaugustus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One image reference to fix.

test/e2e/testing-manifests/scheduling/nvidia-driver-installer.yaml Outdated Show resolved Hide resolved
@hasheddan
Use local daemonset manifest for installing Nvidia drivers
67508f1 
Updates sig-scheduling e2e Nvidia GPU tests to install drivers using
local manifest by default. Currently the DaemonSet is fetched from the
GoogleCloudPlatform/container-enginer-accelerators repo by default.
Using a local manifest allows for manually specifying the image
cos-gpu-installer image rather than always using latest. A remote
manifest can still be fetched by setting
NVIDIA_DRIVER_INSTALLER_DAEMONSET env var.

Signed-off-by: hasheddan <georgedanielmangum@gmail.com>
@hasheddan hasheddan force-pushed the automated-cherry-pick-of-#93207-upstream-release-1.17 branch from c6030fe to 67508f1 Compare July 26, 2020 21:17
@hasheddan
Copy link
Contributor Author

/assign @mikedanese

@justaugustus
Copy link
Member

/assign @alejandrox1 @andrewsykim @cblecker

@hasheddan
Copy link
Contributor Author

/retest

@Huang-Wei
Copy link
Member

/lgtm
/approve

Thanks!

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 27, 2020
@hasheddan
Copy link
Contributor Author

/cc @liggitt

@liggitt
Copy link
Member

liggitt commented Jul 28, 2020

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hasheddan, Huang-Wei, liggitt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 28, 2020
@tpepper
Copy link
Member

tpepper commented Jul 28, 2020

/kind failing-test
/priority critical-urgent
from parent PR

@k8s-ci-robot k8s-ci-robot added kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. and removed needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Jul 28, 2020
@tpepper tpepper added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Jul 28, 2020
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. label Jul 28, 2020
@k8s-ci-robot k8s-ci-robot merged commit 96f7765 into kubernetes:release-1.17 Jul 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@justaugustus justaugustus justaugustus requested changes

@liu-cong liu-cong Awaiting requested review from liu-cong

@neolit123 neolit123 Awaiting requested review from neolit123

@liggitt liggitt Awaiting requested review from liggitt

Assignees

@Huang-Wei Huang-Wei

@cblecker cblecker

@mikedanese mikedanese

@alejandrox1 alejandrox1

@andrewsykim andrewsykim

@ahg-g ahg-g

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/e2e-test-framework Issues or PRs related to refactoring the kubernetes e2e test framework area/test cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. release-note-none Denotes a PR that doesn't merit a release note. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
v1.17
Development

Successfully merging this pull request may close these issues.

None yet