Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Increasing allowed delay for EndpointSlice mirroring integration tests #93497

Merged
merged 1 commit into from Jul 28, 2020
Merged

Increasing allowed delay for EndpointSlice mirroring integration tests #93497

merged 1 commit into from Jul 28, 2020

Conversation

robscott
Copy link
Member

What type of PR is this?
/kind failing-test

What this PR does / why we need it:
This increases the allowed delay for EndpointSlice mirroring integration tests from 5s to 30s. The shorter 5s delay had become a source of flakes.

Which issue(s) this PR fixes:
Fixes #93496

Does this PR introduce a user-facing change?:

NONE

/sig network
/priority critical-urgent
/assign @liggitt

@robscott
Increasing allowed delay for EndpointSlice mirroring integration tests.
eb196be 
The shorter 5s delay had become a source of flakes.
@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. sig/network Categorizes an issue or PR as relevant to SIG Network. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. area/test sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Jul 28, 2020
@robscott robscott mentioned this pull request Jul 28, 2020
Closed
@liggitt
Copy link
Member

liggitt commented Jul 28, 2020

/lgtm
/approve
/milestone v1.19
/retest

@k8s-ci-robot k8s-ci-robot added this to the v1.19 milestone Jul 28, 2020
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 28, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: liggitt, robscott

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 28, 2020
@robscott
Copy link
Member Author

/retest

1 similar comment
@dims
Copy link
Member

dims commented Jul 28, 2020

/retest

@k8s-ci-robot k8s-ci-robot merged commit 8d74486 into kubernetes:master Jul 28, 2020
@robscott robscott deleted the endpointslicemirroring-integration-fix branch March 11, 2021 04:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dims dims Awaiting requested review from dims

@neolit123 neolit123 Awaiting requested review from neolit123

Assignees

@liggitt liggitt

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. release-note-none Denotes a PR that doesn't merit a release note. sig/network Categorizes an issue or PR as relevant to SIG Network. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v1.19
Development

Successfully merging this pull request may close these issues.

[Failing test] TestEndpointSliceMirroring/Service_without_selector
4 participants
@robscott @liggitt @k8s-ci-robot @dims