Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Automated cherry pick of #93515: Use NLB Subnet CIDRs instead of VPC CIDRs in #93611

Merged
merged 1 commit into from
Aug 31, 2020
Merged

Automated cherry pick of #93515: Use NLB Subnet CIDRs instead of VPC CIDRs in #93611

merged 1 commit into from
Aug 31, 2020

Conversation

t0rr3sp3dr0
Copy link
Contributor

Cherry pick of #93515 on release-1.16.

#93515: Use NLB Subnet CIDRs instead of VPC CIDRs in

For details on the cherry pick process, see the cherry pick requests page.

@t0rr3sp3dr0
Use NLB Subnet CIDRs instead of VPC CIDRs in updateInstanceSecurityGr…
e55578e 
…oupsForNLB

Signed-off-by: Pedro Tôrres <t0rr3sp3dr0@gmail.com>
@k8s-ci-robot k8s-ci-robot added this to the v1.16 milestone Jul 31, 2020
@k8s-ci-robot k8s-ci-robot added do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Jul 31, 2020
@k8s-ci-robot
Copy link
Contributor

Hi @t0rr3sp3dr0. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jul 31, 2020
@k8s-ci-robot k8s-ci-robot added sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Jul 31, 2020
@t0rr3sp3dr0
Copy link
Contributor Author

/assign @M00nF1sh

@t0rr3sp3dr0
Copy link
Contributor Author

/assign @jsafrane

@M00nF1sh
Copy link
Contributor

M00nF1sh commented Aug 3, 2020

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 3, 2020
@t0rr3sp3dr0
Copy link
Contributor Author

/test pull-kubernetes-bazel-build

@k8s-ci-robot
Copy link
Contributor

@t0rr3sp3dr0: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/test pull-kubernetes-bazel-build

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@t0rr3sp3dr0
Copy link
Contributor Author

/retest

@k8s-ci-robot
Copy link
Contributor

@t0rr3sp3dr0: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@t0rr3sp3dr0
Copy link
Contributor Author

@M00nF1sh can you add the ok-to-test label? The other cherry picks also have similar problem and I'm not able to trigger retest.

@M00nF1sh
Copy link
Contributor

M00nF1sh commented Aug 5, 2020

/ok-to-test
/retest

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Aug 5, 2020
@t0rr3sp3dr0
Copy link
Contributor Author

/test pull-kubernetes-integration

1 similar comment
@t0rr3sp3dr0
Copy link
Contributor Author

/test pull-kubernetes-integration

@t0rr3sp3dr0
Copy link
Contributor Author

/test pull-kubernetes-verify

4 similar comments
@t0rr3sp3dr0
Copy link
Contributor Author

/test pull-kubernetes-verify

@t0rr3sp3dr0
Copy link
Contributor Author

/test pull-kubernetes-verify

@t0rr3sp3dr0
Copy link
Contributor Author

/test pull-kubernetes-verify

@t0rr3sp3dr0
Copy link
Contributor Author

/test pull-kubernetes-verify

@cpanato
Copy link
Member

cpanato commented Aug 21, 2020

@t0rr3sp3dr0 please work to get this peer reviewed and lgtm/approve.

@cpanato
Copy link
Member

cpanato commented Aug 21, 2020

/kind bug
from parent PR.

@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. and removed needs-kind Indicates a PR lacks a `kind/foo` label and requires one. labels Aug 21, 2020
@t0rr3sp3dr0
Copy link
Contributor Author

t0rr3sp3dr0 commented Aug 21, 2020 •
edited

Hi @cpanato, I was talking to @M00nF1sh and he said we need to wait for 1.19 release before merging this patch. The parent PR is not flagged with 1.19 milestone and cannot be merged at this time. The cherry-picks were already flagged as lgtm but not approved.

@M00nF1sh
Copy link
Contributor

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: M00nF1sh, t0rr3sp3dr0

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 28, 2020
@justaugustus justaugustus added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Aug 31, 2020
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. label Aug 31, 2020
@k8s-ci-robot k8s-ci-robot merged commit 5ee4e16 into kubernetes:release-1.16 Aug 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@justinsb justinsb Awaiting requested review from justinsb

@zmerlynn zmerlynn Awaiting requested review from zmerlynn

Assignees

@jsafrane jsafrane

@M00nF1sh M00nF1sh

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/cloudprovider cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v1.16
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@t0rr3sp3dr0 @k8s-ci-robot @M00nF1sh @cpanato @justaugustus @jsafrane