Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chore correct words #93809

Merged
merged 1 commit into from Aug 27, 2020
Merged

Chore correct words #93809

merged 1 commit into from Aug 27, 2020

Conversation

Howie59
Copy link
Contributor

@Howie59 Howie59 commented Aug 8, 2020 •
edited by liggitt

What type of PR is this?
/kind cleanup

Which issue(s) this PR fixes:

  • Correct words and format codes
NONE

@k8s-ci-robot k8s-ci-robot added do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Aug 8, 2020
@k8s-ci-robot
Copy link
Contributor

Hi @howie66. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Aug 8, 2020
@k8s-ci-robot k8s-ci-robot added sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Aug 8, 2020
@Howie59
Copy link
Contributor Author

Howie59 commented Aug 8, 2020

/assign @deads2k

/assign @deads2k

liggitt
liggitt reviewed Aug 8, 2020
View reviewed changes
Copy link
Member

@liggitt liggitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The typo fixes in the comments look fine (except where noted). Please revert all the variable and file name changes, those all look reasonable as they were.

staging/src/k8s.io/client-go/transport/config.go Outdated Show resolved Hide resolved
staging/src/k8s.io/apimachinery/pkg/watch/watch.go Show resolved Hide resolved
staging/src/k8s.io/apimachinery/pkg/util/validation/validation.go Outdated Show resolved Hide resolved
@liggitt liggitt mentioned this pull request Aug 8, 2020
Closed
@Howie59
Copy link
Contributor Author

Howie59 commented Aug 9, 2020

The typo fixes in the comments look fine (except where noted). Please revert all the variable and file name changes, those all look reasonable as they were.

ok, i have revert the changes you noted, thx

@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Aug 9, 2020
@Howie59 Howie59 requested a review from liggitt August 9, 2020 23:57
@liggitt
Copy link
Member

liggitt commented Aug 10, 2020

looks good, please squash to a single commit, then lgtm

@Howie59
Format Codes
af7cf4a 
Chore: Correct words and format codes

Revert three changes

Revert 1 change

Revert again

Revert 2 changes
@Howie59
Copy link
Contributor Author

Howie59 commented Aug 10, 2020

looks good, please squash to a single commit, then lgtm

ok, i have finished the squash

@liggitt
Copy link
Member

liggitt commented Aug 10, 2020

/lgtm
/approve
/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Aug 10, 2020
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 10, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Howie66, liggitt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 10, 2020
@Howie59
Copy link
Contributor Author

Howie59 commented Aug 10, 2020

/retest

/retest

@k8s-ci-robot
Copy link
Contributor

@howie66: You must be a member of the kubernetes/milestone-maintainers GitHub team to set the milestone. If you believe you should be able to issue the /milestone command, please contact your and have them propose you as an additional delegate for this responsibility.

In response to this:

/milestone v1.19

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@Howie59
Copy link
Contributor Author

Howie59 commented Aug 10, 2020

/kind cleanup

@k8s-ci-robot k8s-ci-robot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. and removed needs-kind Indicates a PR lacks a `kind/foo` label and requires one. labels Aug 10, 2020
@Howie59
Copy link
Contributor Author

Howie59 commented Aug 10, 2020 •
edited

@deads2k
it seems like my issue lack the v1.19, could u add on it?

@k8s-ci-robot
Copy link
Contributor

@howie66: You must be a member of the kubernetes/milestone-maintainers GitHub team to set the milestone. If you believe you should be able to issue the /milestone command, please contact your and have them propose you as an additional delegate for this responsibility.

In response to this:

/milestone v1.19

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@xichengliudui
Copy link
Contributor

/release none

@xichengliudui
Copy link
Contributor

/release-note none

@Howie59
Copy link
Contributor Author

Howie59 commented Aug 10, 2020

@caesarxuchao hi, it seems like my issue lack the /milestone v1.19, could u add on it?

@liggitt
Copy link
Member

liggitt commented Aug 10, 2020

Non-release blocking changes like this will need to wait until master reopens for 1.20. We're currently finalizing the 1.19 release (targeting 8/25) and are in code freeze

@Howie59
Copy link
Contributor Author

Howie59 commented Aug 10, 2020

Non-release blocking changes like this will need to wait until master reopens for 1.20. We're currently finalizing the 1.19 release (targeting 8/25) and are in code freeze

ok, thx

@Howie59
Copy link
Contributor Author

Howie59 commented Aug 27, 2020

@asalkeld @caesarxuchao @liggitt hi, it seems like v1.20 has opened, can this pr be merged?

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Aug 27, 2020
@liggitt liggitt added this to the v1.20-phase-doc-cleanup milestone Aug 27, 2020
@liggitt
Copy link
Member

liggitt commented Aug 27, 2020

This will merge shortly, 1.20 merges are reopening in phases

@justaugustus
Copy link
Member

/test pull-kubernetes-node-e2e

@k8s-ci-robot k8s-ci-robot merged commit 33a7ea7 into kubernetes:master Aug 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asalkeld asalkeld Awaiting requested review from asalkeld

@caesarxuchao caesarxuchao Awaiting requested review from caesarxuchao

@liggitt liggitt Awaiting requested review from liggitt

Assignees

@liggitt liggitt

@deads2k deads2k

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note-none Denotes a PR that doesn't merit a release note. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
v1.20
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@Howie59 @k8s-ci-robot @liggitt @xichengliudui @justaugustus @deads2k