Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(azure): set default value of VmssVirtualMachinesCacheTTLInSeconds when initializing scaleSet #93846

Merged
merged 1 commit into from Aug 11, 2020
Merged

fix(azure): set default value of VmssVirtualMachinesCacheTTLInSeconds when initializing scaleSet #93846

merged 1 commit into from Aug 11, 2020

Conversation

knight42
Copy link
Member

Signed-off-by: knight42 anonymousknight96@gmail.com

What type of PR is this?

/kind flake

What this PR does / why we need it:

Set the default value of VmssVirtualMachinesCacheTTLInSeconds when we are initializing scaleSet rather than every time we invoke newVMSSVirtualMachinesCache to prevent data race.

Which issue(s) this PR fixes:

xref: #93605 (comment)

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@knight42
fix(azure): set default value of VmssVirtualMachinesCacheTTLInSeconds…
1e9f330 
… during init to prevent data race

Signed-off-by: knight42 <anonymousknight96@gmail.com>
@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/flake Categorizes issue or PR as related to a flaky test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Aug 10, 2020
@k8s-ci-robot k8s-ci-robot added area/cloudprovider sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Aug 10, 2020
@knight42 knight42 mentioned this pull request Aug 10, 2020
Merged
37 tasks
@nilo19
Copy link
Member

nilo19 commented Aug 10, 2020

/lgtm
/retest

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 10, 2020
@nilo19
Copy link
Member

nilo19 commented Aug 11, 2020 •
edited

thanks for the fix

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: knight42, nilo19

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 11, 2020
@nilo19
Copy link
Member

nilo19 commented Aug 11, 2020

/priority important-soon
/milestone v1.19

@k8s-ci-robot k8s-ci-robot added the priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. label Aug 11, 2020
@k8s-ci-robot
Copy link
Contributor

@nilo19: You must be a member of the kubernetes/milestone-maintainers GitHub team to set the milestone. If you believe you should be able to issue the /milestone command, please contact your and have them propose you as an additional delegate for this responsibility.

In response to this:

/priority important-soon
/milestone v1.19

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot removed the needs-priority Indicates a PR lacks a `priority/foo` label and requires one. label Aug 11, 2020
@feiskyer
Copy link
Member

/milestone v1.19

@k8s-ci-robot k8s-ci-robot added this to the v1.19 milestone Aug 11, 2020
@knight42
Copy link
Member Author

/retest

@k8s-ci-robot k8s-ci-robot merged commit 0436287 into kubernetes:master Aug 11, 2020
@knight42 knight42 deleted the fix/TestEnsureBackendPoolDeletedConcurrently branch August 11, 2020 04:13
@liggitt
Copy link
Member

liggitt commented Aug 11, 2020

thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nilo19 nilo19 Awaiting requested review from nilo19

@ritazh ritazh Awaiting requested review from ritazh

Assignees

@nilo19 nilo19

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/cloudprovider cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/flake Categorizes issue or PR as related to a flaky test. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note-none Denotes a PR that doesn't merit a release note. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v1.19
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@knight42 @nilo19 @k8s-ci-robot @feiskyer @liggitt