Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"unbound immediate PersistentVolumeClaims" should be UnschedulableAnd… #93892

Merged
merged 1 commit into from Aug 24, 2020
Merged

"unbound immediate PersistentVolumeClaims" should be UnschedulableAnd… #93892

merged 1 commit into from Aug 24, 2020

Conversation

ahg-g
Copy link
Member

@ahg-g ahg-g commented Aug 11, 2020 •
edited

What type of PR is this?

/kind bug

What this PR does / why we need it:

"unbound immediate PersistentVolumeClaims" should be UnschedulableAndUnresolvable error

This was fixed in 1.19 by refactoring that part into PreFilter in #91775

This is a bug because it is currently causing incorrect reporting in scheduling_attempts metric (internal error vs unschedulable).

Which issue(s) this PR fixes:
Fixes ##91755

Does this PR introduce a user-facing change?:

"unbound immediate PersistentVolumeClaims" causes UnschedulableAndUnresolvable status rather than an Error in the scheduler.

@ahg-g
"unbound immediate PersistentVolumeClaims" should be UnschedulableAnd…
d9f5320 
…Unresolvable error

This was fixed in 1.19 by refactoring that part into PreFilter in kubernetes#91775
@k8s-ci-robot k8s-ci-robot added do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. release-note-none Denotes a PR that doesn't merit a release note. labels Aug 11, 2020
@k8s-ci-robot k8s-ci-robot added this to the v1.18 milestone Aug 11, 2020
@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Aug 11, 2020
@ahg-g
Copy link
Member Author

ahg-g commented Aug 11, 2020

/assign @cofyc @msau42 @alculquicondor

ahg-g
ahg-g commented Aug 11, 2020
View reviewed changes
pkg/controller/volume/scheduling/scheduler_binder_test.go
@@ -809,9 +809,9 @@ func TestFindPodVolumesWithoutProvisioning(t *testing.T) {
shouldFail: true,
},
"prebound-pvc": {
podPVCs: []*v1.PersistentVolumeClaim{preboundPVC},
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cofyc can you double check if the change to this test case is expected?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes

pkg/controller/volume/scheduling/scheduler_binder_test.go
@@ -850,9 +850,9 @@ func TestFindPodVolumesWithoutProvisioning(t *testing.T) {
reasons: ConflictReasons{ErrReasonBindConflict},
},
"one-prebound,one-unbound": {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ditto,@cofyc can you double check if the change to this test case is expected?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes

@alculquicondor
Copy link
Member

lgtm from scheduling PoV

@cofyc
Copy link
Member

cofyc commented Aug 12, 2020

/lgtm
/retest

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 12, 2020
@msau42
Copy link
Member

msau42 commented Aug 12, 2020

/approve

I think all cherry-picks need a release note.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahg-g, msau42

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-none Denotes a PR that doesn't merit a release note. labels Aug 12, 2020
@ahg-g
Copy link
Member Author

ahg-g commented Aug 12, 2020

/sig-storage
/priority important-soon
@kubernetes/release-managers

@k8s-ci-robot k8s-ci-robot added priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. and removed needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Aug 12, 2020
@ahg-g
Copy link
Member Author

ahg-g commented Aug 12, 2020

/sig storage

@k8s-ci-robot k8s-ci-robot added sig/storage Categorizes an issue or PR as relevant to SIG Storage. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Aug 12, 2020
@ahg-g
Copy link
Member Author

ahg-g commented Aug 12, 2020

/retest

2 similar comments
@ahg-g
Copy link
Member Author

ahg-g commented Aug 12, 2020

/retest

@ahg-g
Copy link
Member Author

ahg-g commented Aug 12, 2020

/retest

@ahg-g
Copy link
Member Author

ahg-g commented Aug 19, 2020

friendly ping @kubernetes/release-managers

@ahg-g
Copy link
Member Author

ahg-g commented Aug 21, 2020

@justaugustus can you please take a look at this PR?

hasheddan
hasheddan approved these changes Aug 24, 2020
View reviewed changes
Copy link
Contributor

@hasheddan hasheddan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@hasheddan hasheddan added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Aug 24, 2020
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. label Aug 24, 2020
@ahg-g
Copy link
Member Author

ahg-g commented Aug 24, 2020

/retest

@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@k8s-ci-robot k8s-ci-robot merged commit 52a2c07 into kubernetes:release-1.18 Aug 24, 2020
@ahg-g ahg-g deleted the ahg-volume2 branch October 25, 2021 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hasheddan hasheddan hasheddan approved these changes

@cofyc cofyc Awaiting requested review from cofyc

@msau42 msau42 Awaiting requested review from msau42

Assignees

@cofyc cofyc

@alculquicondor alculquicondor

@msau42 msau42

@hasheddan hasheddan

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/apps Categorizes an issue or PR as relevant to SIG Apps. sig/storage Categorizes an issue or PR as relevant to SIG Storage. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v1.18
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@ahg-g @alculquicondor @cofyc @msau42 @k8s-ci-robot @fejta-bot @hasheddan