[go1.15] Update to go1.15 #93939
[go1.15] Update to go1.15 #93939
Conversation
k8s-ci-robot
added
release-note
| @@ -16,7 +16,7 @@ REGISTRY ?= gcr.io/kubernetes-e2e-test-images | |||
| GOARM ?= 7 | |||
| DOCKER_CERT_BASE_PATH ?= | |||
| QEMUVERSION=v2.9.1 | |||
| GOLANG_VERSION=1.15rc2 | |||
| GOLANG_VERSION=1.15.0 | |||
There was a problem hiding this comment.
is this just 1.15 or is it 1.15.0?
There was a problem hiding this comment.
the docker image includes the .0 馃槣
build/root/WORKSPACE
Outdated
| #go_version = "1.15.0", | ||
| # TODO(go1.15): Comment out once we've published a repo-infra release that supports go1.15 | ||
| override_go_version = "1.15.0-rc.2", | ||
| go_version = "1.15.0", |
There was a problem hiding this comment.
unknown Go version: 1.15.0
should this be "1.15"?
There was a problem hiding this comment.
this missing ".0" really bugs me
There was a problem hiding this comment.
It really bugs me too.
There was a problem hiding this comment.
w00t! i caught something in my review.... now make me an approver :)
|
/retitle [go1.15] Update to go1.15 |
|
don't forget to update the release notes too! go doesn't have .0 versions 馃檮
|
|
Yep, it's throwing errors because of the .0. I'm fixing up regexes locally :) |
Signed-off-by: Stephen Augustus <saugustus@vmware.com>
Signed-off-by: Stephen Augustus <saugustus@vmware.com>
Signed-off-by: Stephen Augustus <saugustus@vmware.com>
|
/milestone v1.19 |
| - name: "golang: upstream container image" | ||
| version: 1.15rc2 | ||
| refPaths: | ||
| match: (override_)?go_version = "\d+.\d+(alpha|beta|rc)?\.?\d+" |
There was a problem hiding this comment.
I think you want something like:
"\d+\.\d+(alpha\d*|beta\d*|rc\d*|\.\d+)?"
# one or more digits, followed by .
\d+\.
# one or more digits
\d+
# optionally followed by alpha/beta/rc of any number, or a specific patch release
(
alpha\d*
|
beta\d*
|
rc\d*
|
\.\d+
)?
There was a problem hiding this comment.
follow up for this is fine, just noting that the only reason this currently passes 1.15 is:
"\d+.\d+(alpha|beta|rc)?\.?\d+"
"1 .1 5"
and the . in the regex would match any character, not just a literal .
There was a problem hiding this comment.
Yep, will issue a follow up to clean up some of the regex in dependencies.yaml.
It's a bit Wild Wild West in there at this point.
|
/lgtm followups:
|
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: justaugustus, liggitt The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
/priority critical-urgent |
k8s-ci-robot
added
priority/critical-urgent
opened in #93969 |
What type of PR is this?
/kind cleanup
/area dependency release-eng
/sig release
What this PR does / why we need it:
IT'S HAPPENING 馃帀
Update to go1.15.0
Signed-off-by: Stephen Augustus saugustus@vmware.com
cc: @kubernetes/release-engineering @kubernetes/release-team-leads @kubernetes/sig-release-admins @kubernetes/sig-scalability @liggitt @dims
Tracking issue: kubernetes/release#1421
Special notes for your reviewer:
Does this PR introduce a user-facing change?: