New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make CSI mock driver log parse more flexible #93950
Conversation
Hi @Jiawei0227. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test |
40ae913
to
0ce86eb
Compare
/lgtm |
/retest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Jiawei0227, msau42, pohly The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
This PR makes the mock CSI driver log parse function more flexible to embrace the future change where we use klog instead of
fmt.print
for mock csi driver logging.Which issue(s) this PR fixes:
Fixes
Special notes for your reviewer:
This is for #93358. It would be good if we can get an idea of the timestamps of all the events happened in mock CSI driver. But in order to do that, we need to flexible the tests first.
This is a prerequisite for this PR: kubernetes-csi/csi-test#279
Does this PR introduce a user-facing change?:
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:
/cc @msau42
/cc @pohly
/cc @gnufied
/sig storage