New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(api): 馃摑 Fix HPA docs with addition of "External" type #94010
docs(api): 馃摑 Fix HPA docs with addition of "External" type #94010
Conversation
Welcome @ghostsquad! |
Hi @ghostsquad. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/assign @lavalamp |
This PR may require API review. If so, when the changes are ready, complete the pre-review checklist and request an API review. Status of requested reviews is tracked in the API Review project. |
/ok-to-test |
/sig api-machinery |
/lgtm |
You will need to regenerate all the stuff. hack/update-generated-all.sh or something like that. |
/retest |
/assign @lavalamp |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ghostsquad, lavalamp The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@lavalamp what's next here? there's still a |
What type of PR is this?
/kind documentation
What this PR does / why we need it:
Documentation did not accurately describe the valid values of
Type
for HPAs.Which issue(s) this PR fixes:
N/A
Special notes for your reviewer:
N/A
Does this PR introduce a user-facing change?:
N/A
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:
N/A