New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Agnhost version sync #94152
Agnhost version sync #94152
Conversation
these have de-synced multiple times. most recently caught in #94135 (comment) |
match: "Version:" | ||
|
||
# then after merge and successful postsubmit image push / promotion, bump this | ||
- name: "agnhost: dependents" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suspect there are more, but I didn't turn up any that are obviously intended to be in sync here yet.
If nothing else though, this entry should prevent an incorrect addition of this file to the entry above.
There is also the rarely updated private image from this that we literally only use to test pulling a private image (w/ auth).
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: BenTheElder, justaugustus The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This missed updating test/utils/image/manifest.go, suggested update in https://github.com/kubernetes/kubernetes/pull/89582/files#r480392573 |
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
I also:
Does this PR introduce a user-facing change?:
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: