Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a link to liggitt's deflake docs in Flake template #94243

Merged
merged 2 commits into from
Aug 28, 2020
Merged

Add a link to liggitt's deflake docs in Flake template #94243

merged 2 commits into from
Aug 28, 2020

Conversation

MushuEE
Copy link
Contributor

@MushuEE MushuEE commented Aug 26, 2020

We could have prow bot link comment the link but I think this should be enough to increase visibility to the doc when people encounter a flake

What type of PR is this?
/kind documentation

What this PR does / why we need it:
Increases visibility of @liggitt 's wonderful deflake document

Does this PR introduce a user-facing change?:

NONE

/cc @spiffxp @liggitt

@MushuEE
Add a link to liggitt's deflake docs in template
49d9791 
We could have prow bot link comment the link but I think this should be enough to increase visibility to the doc when people encouter a flake
@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/documentation Categorizes issue or PR as related to documentation. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. sig/contributor-experience Categorizes an issue or PR as relevant to SIG Contributor Experience. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Aug 26, 2020
@liggitt
Copy link
Member

liggitt commented Aug 26, 2020

https://github.com/kubernetes/community/blob/master/contributors/devel/sig-testing/flaky-tests.md might be a more canonical page. I'd like to see useful bits hoisted from the presentation into that page.

@MushuEE
Copy link
Contributor Author

MushuEE commented Aug 26, 2020

@liggitt thanks, I don't mind updating that as well unless you feel strongly about how it gets organized with your updates
/label tide/merge-method-squash

@k8s-ci-robot k8s-ci-robot added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label Aug 26, 2020
hasheddan
hasheddan approved these changes Aug 26, 2020
View reviewed changes
Copy link
Contributor

@hasheddan hasheddan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/retest

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 26, 2020
spiffxp
spiffxp approved these changes Aug 26, 2020
View reviewed changes
Copy link
Member

@spiffxp spiffxp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

@dims
Copy link
Member

dims commented Aug 27, 2020

/assign @cblecker @nikhita

nikhita
nikhita approved these changes Aug 27, 2020
View reviewed changes
Copy link
Member

@nikhita nikhita left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: MushuEE, nikhita, spiffxp

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 27, 2020
@justaugustus justaugustus added this to the v1.20 milestone Aug 27, 2020
@k8s-ci-robot k8s-ci-robot merged commit cfac09a into kubernetes:master Aug 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spiffxp spiffxp spiffxp approved these changes

@nikhita nikhita nikhita approved these changes

@hasheddan hasheddan hasheddan approved these changes

@liggitt liggitt Awaiting requested review from liggitt

Assignees

@spiffxp spiffxp

@cblecker cblecker

@nikhita nikhita

@hasheddan hasheddan

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/documentation Categorizes issue or PR as related to documentation. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. release-note-none Denotes a PR that doesn't merit a release note. sig/contributor-experience Categorizes an issue or PR as relevant to SIG Contributor Experience. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.
Projects
None yet
Milestone
v1.20
Development

Successfully merging this pull request may close these issues.

None yet
9 participants
@MushuEE @liggitt @dims @k8s-ci-robot @spiffxp @nikhita @hasheddan @justaugustus @cblecker