Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deflake cpumanager checkpoint unit tests #94541

Merged
merged 1 commit into from Sep 5, 2020
Merged

Deflake cpumanager checkpoint unit tests #94541

merged 1 commit into from Sep 5, 2020

Conversation

liggitt
Copy link
Member

@liggitt liggitt commented Sep 4, 2020

What type of PR is this?

/kind flake

What this PR does / why we need it:

Gives each test its own tmpdir, instead of using the root tempdir

Which issue(s) this PR fixes:
xref #94528 (comment) and https://testgrid.k8s.io/sig-release-master-blocking#bazel-test-master&width=20&sort-by-name=&include-filter-by-regex=pkg/kubelet/cm/cpumanager/state

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/flake Categorizes issue or PR as related to a flaky test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Sep 4, 2020
@liggitt liggitt mentioned this pull request Sep 4, 2020
Closed
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: liggitt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. area/kubelet sig/node Categorizes an issue or PR as relevant to SIG Node. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Sep 4, 2020
hasheddan
hasheddan approved these changes Sep 4, 2020
View reviewed changes
Copy link
Contributor

@hasheddan hasheddan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 4, 2020
@hasheddan
Copy link
Contributor

/retest

@liggitt liggitt added the priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. label Sep 4, 2020
@k8s-ci-robot k8s-ci-robot removed the needs-priority Indicates a PR lacks a `priority/foo` label and requires one. label Sep 4, 2020
@liggitt liggitt added this to the v1.20 milestone Sep 4, 2020
@liggitt liggitt mentioned this pull request Sep 4, 2020
Merged
37 tasks
@liggitt
Copy link
Member Author

liggitt commented Sep 4, 2020

unrelated bazel fetch error:

ERROR: /bazel-scratch/.cache/bazel/_bazel_root/7989b31489f31aee54f32688da2f0120/external/io_bazel_rules_go/go/tools/builders/BUILD.bazel:46:1: @io_bazel_rules_go//go/tools/builders:nogo_srcs depends on @org_golang_x_tools//go/analysis:go_tool_library in repository @org_golang_x_tools which failed to fetch. no such package '@org_golang_x_tools//go/analysis': failed to fetch org_golang_x_tools: fetch_repo: golang.org/x/tools@v0.0.0-20200710042808-f1c4188a97a1: unexpected EOF
ERROR: Analysis of target '//test/instrumentation:verify_stable_metric' failed; build aborted: no such package '@org_golang_x_tools//go/analysis': failed to fetch org_golang_x_tools: fetch_repo: golang.org/x/tools@v0.0.0-20200710042808-f1c4188a97a1: unexpected EOF

/retest

@liggitt
Copy link
Member Author

liggitt commented Sep 4, 2020

/retest

1 similar comment
@liggitt
Copy link
Member Author

liggitt commented Sep 4, 2020

/retest

@k8s-ci-robot k8s-ci-robot merged commit 60c421b into kubernetes:master Sep 5, 2020
@liggitt liggitt deleted the deflake-cpucheckpoint branch September 6, 2020 02:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hasheddan hasheddan hasheddan approved these changes

@klueska klueska Awaiting requested review from klueska

@krmayankk krmayankk Awaiting requested review from krmayankk

Assignees

@hasheddan hasheddan

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/kubelet cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/flake Categorizes issue or PR as related to a flaky test. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. release-note-none Denotes a PR that doesn't merit a release note. sig/node Categorizes an issue or PR as relevant to SIG Node. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v1.20
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@liggitt @k8s-ci-robot @hasheddan