Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(kuberuntime): deflake TestRecordOperation #94549

Merged
merged 1 commit into from Sep 5, 2020
Merged

test(kuberuntime): deflake TestRecordOperation #94549

merged 1 commit into from Sep 5, 2020

Conversation

knight42
Copy link
Member

@knight42 knight42 commented Sep 5, 2020 •
edited

Signed-off-by: knight42 anonymousknight96@gmail.com

What type of PR is this?

/kind flake

What this PR does / why we need it:

https://prow.k8s.io/view/gcs/kubernetes-jenkins/logs/periodic-kubernetes-bazel-test-master/1302097743879081990

=== RUN   TestRecordOperation
    instrumented_services_test.go:39: 
        	Error Trace:	instrumented_services_test.go:39
        	Error:      	Received unexpected error:
        	            	listen tcp 127.0.0.1:1234: bind: address already in use
        	Test:       	TestRecordOperation
--- FAIL: TestRecordOperation (0.00s)

Avoid using hard-coded port

Which issue(s) this PR fixes:

Part of #94528

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@knight42
test(kuberuntime): deflake TestRecordOperation
c6f9b40 
Avoid using hard-coded port

Signed-off-by: knight42 <anonymousknight96@gmail.com>
@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/flake Categorizes issue or PR as related to a flaky test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Sep 5, 2020
@knight42
Copy link
Member Author

knight42 commented Sep 5, 2020

/cc @liggitt

@k8s-ci-robot k8s-ci-robot added area/kubelet sig/node Categorizes an issue or PR as relevant to SIG Node. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Sep 5, 2020
@liggitt
Copy link
Member

liggitt commented Sep 5, 2020

/lgtm
/approve
/milestone v1.20
/priority important-soon

@k8s-ci-robot k8s-ci-robot added the priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. label Sep 5, 2020
@k8s-ci-robot k8s-ci-robot added this to the v1.20 milestone Sep 5, 2020
@k8s-ci-robot k8s-ci-robot removed the needs-priority Indicates a PR lacks a `priority/foo` label and requires one. label Sep 5, 2020
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 5, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: knight42, liggitt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 5, 2020
@k8s-ci-robot k8s-ci-robot merged commit 22772d0 into kubernetes:master Sep 5, 2020
@knight42 knight42 deleted the fix/TestRecordOperation branch September 5, 2020 16:04
This was referenced Sep 5, 2020
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liggitt liggitt Awaiting requested review from liggitt

@dchen1107 dchen1107 Awaiting requested review from dchen1107

@odinuge odinuge Awaiting requested review from odinuge

Assignees

@liggitt liggitt

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/kubelet cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/flake Categorizes issue or PR as related to a flaky test. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note-none Denotes a PR that doesn't merit a release note. sig/node Categorizes an issue or PR as relevant to SIG Node. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v1.20
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@knight42 @liggitt @k8s-ci-robot